From: Matthias Heiserer <m.heiserer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [pbs-devel] [PATCH widget-toolkit] CSS: import action column fix from pbs, pmg
Date: Fri, 7 Oct 2022 11:06:28 +0200 [thread overview]
Message-ID: <86a04d9d-ecbe-36c5-a3f0-19f5cb9ae681@proxmox.com> (raw)
In-Reply-To: <677a9e78-033e-dfb5-9057-8b1eff231c96@proxmox.com>
On 05.10.2022 17:45, Thomas Lamprecht wrote:
> Am 20/07/2022 um 14:22 schrieb Matthias Heiserer:
>> So it is in one location and available to pve as well.
>>
>> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
>> ---
>> src/css/ext6-pmx.css | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/src/css/ext6-pmx.css b/src/css/ext6-pmx.css
>> index 886e24a..2286003 100644
>> --- a/src/css/ext6-pmx.css
>> +++ b/src/css/ext6-pmx.css
>> @@ -274,3 +274,18 @@ div.right-aligned {
>> /* markdown tables end */
>>
>> /* markdown content end */
>> +
>> +/* fix action column icons */
>> +.x-action-col-icon:before {
>> + color: #555;
>> +}
>> +
>> +.x-action-col-icon {
>> + font-size: 13px;
>> + height: 13px;
>> +}
>
> this is using the outdated/wrong ones, the font awesome icons we use are 14px.
> Please use the modern ones from PBS and maybe add the additional ones, like:
>
> .x-action-col-icon {
> margin: 0 1px;
> font-size: 14px;
> }
> .x-action-col-icon:before, .x-action-col-icon:after {
> font-size: 14px;
> }
> .x-action-col-icon:hover:before, .x-action-col-icon:hover:after {
> text-shadow: 1px 1px 1px #AAA;
> font-weight: 800;
> }
>
> Note that it's a bit confusing because in PBS the previous & wrong 13px font-size
> rule didn't get removed..
Oh, good catch. I was confused myself because I only saw the 13px ones
and figured we intentionally use a different size there. Will fix it in v2.
>
>
>> +
>> +.x-grid-cell-inner-action-col {
>> + padding: 6px 10px 5px;
>> +}
>> +/* fix action column icons end*/
>> \ No newline at end of file
>
prev parent reply other threads:[~2022-10-07 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 12:22 [pmg-devel] [PATCH proxmox-backup] GUI: CSS: move action columns fix to widget-toolkit Matthias Heiserer
2022-07-20 12:22 ` [pmg-devel] [PMG-GUI] CSS: action columns: move " Matthias Heiserer
2022-07-20 12:22 ` [pmg-devel] [PATCH widget-toolkit] CSS: import action column fix from pbs, pmg Matthias Heiserer
2022-10-05 15:45 ` [pmg-devel] [pbs-devel] " Thomas Lamprecht
2022-10-07 9:06 ` Matthias Heiserer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a04d9d-ecbe-36c5-a3f0-19f5cb9ae681@proxmox.com \
--to=m.heiserer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox