public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Matthias Heiserer <m.heiserer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	pmg-devel@lists.proxmox.com, pve-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [pbs-devel] [PATCH v2 proxmox-backup 1/2] GUI: CSS: remove redundant action column style
Date: Mon, 28 Nov 2022 15:36:52 +0100	[thread overview]
Message-ID: <7e977e99-f586-5b9a-4121-aee36cd59a4d@proxmox.com> (raw)
In-Reply-To: <59f5469a-0502-c715-4be3-6157f3f5f2fa@proxmox.com>

On 28.11.2022 08:32, Thomas Lamprecht wrote:
> Am 07/10/2022 um 13:18 schrieb Matthias Heiserer:
>> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
>> ---
>>
>> Changes from v1:
>> remove both action column styles
>>
>>   www/css/ext6-pbs.css | 14 --------------
>>   1 file changed, 14 deletions(-)
>>
>> diff --git a/www/css/ext6-pbs.css b/www/css/ext6-pbs.css
>> index 3c8bed55..7fc60eee 100644
>> --- a/www/css/ext6-pbs.css
>> +++ b/www/css/ext6-pbs.css
>> @@ -127,20 +127,6 @@ table:not(.x-grid-item-selected) tr.x-grid-row.disabled {
>>       color: #cfcfcf;
>>   }
>>   
>> -/* fix action column icons */
>> -.x-action-col-icon {
>> -    font-size: 13px;
>> -    height: 13px;
>> -}
>> -
>> -.x-grid-cell-inner-action-col {
>> -    padding: 6px 10px 5px;
>> -}
> 
> ^- above rule gets lost and bloats up vertical padding quite a bit in the progress,
> there's no commit message so a bit hard to tell, but just from the subject I'd think
> that this is meant to be done, or?
I figured we want to have the same style on all products.
Should I send a v2 and keep this line in PBS, or add it to the widget 
toolkit?

> 
>> -
>> -.x-action-col-icon:before {
>> -    color: #555;
>> -}
>> -
>>   .x-treelist-item-icon {
>>       color: #000;
>>   }
> 





  reply	other threads:[~2022-11-28 14:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 11:18 [pmg-devel] [PATCH v2 widget-toolkit] CSS: import action column fix from pbs, pmg Matthias Heiserer
2022-10-07 11:18 ` [pmg-devel] [PATCH v2 pmg-gui] CSS: move action column fix to widget-toolkit Matthias Heiserer
2022-10-07 11:18 ` [pmg-devel] [PATCH v2 proxmox-backup 1/2] GUI: CSS: remove redundant action column style Matthias Heiserer
2022-11-28  7:32   ` [pmg-devel] [pbs-devel] " Thomas Lamprecht
2022-11-28 14:36     ` Matthias Heiserer [this message]
2022-10-07 11:18 ` [pmg-devel] [PATCH v2 proxmox-backup 2/2] GUI: CSS: move action columns fix to widget-toolkit Matthias Heiserer
2022-11-28  8:24   ` [pmg-devel] applied: " Thomas Lamprecht
2022-10-10  8:02 ` [pmg-devel] applied: [pve-devel] [PATCH v2 widget-toolkit] CSS: import action column fix from pbs, pmg Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e977e99-f586-5b9a-4121-aee36cd59a4d@proxmox.com \
    --to=m.heiserer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal