From: Mira Limbeck <m.limbeck@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH log-tracker v2] use pico-args instead of clap
Date: Tue, 13 Feb 2024 11:54:28 +0100 [thread overview]
Message-ID: <76bff08e-d283-480c-b686-83e51d544b8a@proxmox.com> (raw)
In-Reply-To: <20231025112026.4109852-1-d.csapak@proxmox.com>
On 10/25/23 13:20, Dominik Csapak wrote:
> Instead of upgrading from clap3 to clap4 (which seems to change their
> interface every year or so), switch to the much smaller pico-args. (Same
> as we did for termproxy recently, see [0])
Got rid of 13 dependencies, while adding 1 (pico-args) according to
`cargo update` output.
> It has almost all features we need (except producing help output) and
> supports OsString, but wihout any dependencies. This decreases compile
> time and reduces the size of the resulting binary. It also reduces the
> lines of code.
>
> The only difference is now the different output for errors, e.g. for
> missing values of options.
>
> Help output is copied from the old clap output.
>
> 0: https://git.proxmox.com/?p=pve-xtermjs.git;a=commitdiff;h=24d707d0506b120a085b06b5f2b6000696879a1e
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * extracted the pkg_version into a variable for interpolated use
> * improved commit message, e.g. by referencing the termproxy commit
>
> Cargo.toml | 2 +-
> src/main.rs | 223 +++++++++++++++++++---------------------------------
> 2 files changed, 83 insertions(+), 142 deletions(-)
>
Looks good to me.
Tested it both via GUI (which calls the CLI) and the CLI directly.
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
Reviewed-by: Mira Limbeck <m.limbeck@proxmox.com>
next prev parent reply other threads:[~2024-02-13 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 11:20 Dominik Csapak
2024-02-13 10:54 ` Mira Limbeck [this message]
2024-02-13 14:56 ` [pmg-devel] applied: " Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76bff08e-d283-480c-b686-83e51d544b8a@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox