From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api v2] backup: restore: keep directories in /etc/pmg for inotify
Date: Mon, 12 Dec 2022 13:18:11 +0100 [thread overview]
Message-ID: <718c3996-85c5-2f54-bcd2-af479d71241c@proxmox.com> (raw)
In-Reply-To: <20221130170727.85325-1-s.ivanov@proxmox.com>
Am 30/11/2022 um 18:07 schrieb Stoiko Ivanov:
> By wiping the subdirectories in /etc/pmg/, we lose the inotify
> watchers upon restore (/etc/pmg itself and thus most configs are
> currently handled by the keep_root flag to rmtree)
> This can lead to inconsistencies after restoring for parts relying on
> config in a subdirectory (e.g. /etc/pmg/pbs/pbs.conf).
>
> This patch uses File::Find (included in perl-modules-$perlver) to keep
> all directories an unlink everything else.
> This was chosen for future robustness over keeping an explicit list of
> directories to keep, in case a new directory gets added.
>
> quickly tested with a fifo, chardev, and socket in the directory.
>
> an alternative approach would be to simply reload pmgdaemon/pmgproxy
> upon config-restore, but that feels more likely to miss some
> (potentially future) service, expecting inotify to work.
>
> Reported-by: Fiona Ebner <f.ebner@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> v1->v2:
> * do not track an explicit list of directories, but simply keep all
> (as suggested by Fiona)
> * use File::Find, since it's present if perl-modules is installed
>
> I did not put this in a helper by itself in pve-common, because it seems
> short/direct enough to not warrant it.
>
> src/PMG/Backup.pm | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
>
applied, with Fiona's T-b, thanks!
I changed the find call to directly pass the code ref sub, as I found using
the "wanted" option not really helpful (name makes it sound like it would have
some influence on descending, but it really is just a dumb callback).
Also caught ENOENT error explicitly from the unlink invocation, while not _that_
likely IMO still a good practice.
prev parent reply other threads:[~2022-12-12 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:07 [pmg-devel] " Stoiko Ivanov
2022-12-05 9:51 ` Fiona Ebner
2022-12-12 12:18 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=718c3996-85c5-2f54-bcd2-af479d71241c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox