From: Mira Limbeck <m.limbeck@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui v3] fix #4510: add filter box to many grids
Date: Wed, 21 Feb 2024 15:57:13 +0100 [thread overview]
Message-ID: <6e8391cc-02bb-4fd9-aeac-9bf3bb9ac419@proxmox.com> (raw)
In-Reply-To: <20240221144744.3850083-1-d.csapak@proxmox.com>
On 2/21/24 15:47, Dominik Csapak wrote:
> namely relay domains, transports, trusted networks, smtp whitelist +
> when/what/who object grids.
>
> Adds a new 'FilterField', that takes a store and a list of columns to
> filter, and filters on every change.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v3:
> * always clear the old filters on the store when the value changes
> otherwise we only add filter but never remove them
>
> js/Makefile | 1 +
> js/MyNetworks.js | 5 ++++
> js/ObjectGroup.js | 11 ++++++++
> js/RelayDomains.js | 5 ++++
> js/Transport.js | 5 ++++
> js/form/FilterField.js | 57 ++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 84 insertions(+)
> create mode 100644 js/form/FilterField.js
>
lgtm
Tested-by: Mira Limbeck <m.limbeck@proxmox.com>
next prev parent reply other threads:[~2024-02-21 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 14:47 Dominik Csapak
2024-02-21 14:57 ` Mira Limbeck [this message]
2024-02-21 17:10 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e8391cc-02bb-4fd9-aeac-9bf3bb9ac419@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox