public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied-series: [PATCH pmg-api/gui/docs v2] ruledb disclaimer improvements
Date: Fri, 23 Feb 2024 09:01:06 +0100	[thread overview]
Message-ID: <6bb89cc0-f893-41e0-ae8e-77e0b0f35f27@proxmox.com> (raw)
In-Reply-To: <20240115111242.2781994-1-d.csapak@proxmox.com>

Am 15/01/2024 um 12:12 schrieb Dominik Csapak:
> add 'position' and 'add-separator' options for disclaimers
> 
> maybe someone has a better idea for how i handle the database
> updates
> 
> changes from v1:
> * add docs patch
> * rebase on master
> * change 'top' parameter to 'position' (internally still 'top')
> * change how we set default values, so that they don't end up in the
>   database
> 
> pmg-api:
> 
> Dominik Csapak (2):
>   fix #2606: ruledb disclaimer: add ability to set position
>   fix #2430: ruledb disclaimer: make separator configurable
> 
>  src/PMG/RuleDB/Disclaimer.pm | 78 +++++++++++++++++++++++++++++++++---
>  1 file changed, 73 insertions(+), 5 deletions(-)
> 
> pmg-gui:
> 
> Dominik Csapak (2):
>   disclaimer edit: add position comobobox
>   disclaimer edit: add 'add-separator' checkbox
> 
>  js/Utils.js | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> pmg-docs:
> 
> Dominik Csapak (1):
>   add disclaimer position/separator docs
> 
>  pmg-mail-filter.adoc | 5 +++++
>  1 file changed, 5 insertions(+)
> 


applied series, had to fix one issue in GUI patch 2/2 though (see reply
there), thanks!




      parent reply	other threads:[~2024-02-23  8:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 11:12 [pmg-devel] " Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-api v2 1/2] fix #2606: ruledb disclaimer: add ability to set position Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-api v2 2/2] fix #2430: ruledb disclaimer: make separator configurable Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-gui v2 1/2] disclaimer edit: add position comobobox Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-gui v2 2/2] disclaimer edit: add 'add-separator' checkbox Dominik Csapak
2024-02-23  8:02   ` Thomas Lamprecht
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-docs v2 1/1] add disclaimer position/separator docs Dominik Csapak
2024-02-23  8:01 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bb89cc0-f893-41e0-ae8e-77e0b0f35f27@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal