From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api 0/2] remove unused greylist table column and make test_gl more robust
Date: Wed, 16 Jun 2021 13:04:14 +0200 [thread overview]
Message-ID: <6123a046-2757-e956-b201-cd0243bee6b3@proxmox.com> (raw)
In-Reply-To: <20210611155447.9162-1-s.ivanov@proxmox.com>
looks good, works as advertised.
did not matter if i upgraded a master node first or not
(since we did not rely on the host column any more anyway)
nice :)
i could not reproduce the original problem of the second patch,
but it did not break it, so also ok
Reviewed-By: Dominik Csapak <d.csapak@proxmox.com>
Tested-By: Dominik Csapak <d.csapak@proxmox.com>
On 6/11/21 5:54 PM, Stoiko Ivanov wrote:
> These two patches are the result from some intial trials to build and test
> PMG on debian bullseye
>
> The first drops a deprecated database column, and since I consider changes
> to the database schema somewhat sensitive I'd like another set of eyes
> to look over the changes
>
> the second patch addresses a timing issue in test_greylist.pl, which
> causes the tests to fail, because the policy daemon is not accepting
> connections early enough (at least on my test-container with bullseye)
> One alternative would be to skip the greylist tests here which would
> enables building as non-root user.
>
> Stoiko Ivanov (2):
> greylisting: drop unneeded Host column form cgreylist table
> tests: greylist: retry connecting 3 times
>
> src/PMG/Cluster.pm | 3 +--
> src/PMG/DBTools.pm | 21 +++++++++++++++------
> src/bin/pmgpolicy | 6 ++----
> src/tests/test_greylist.pl | 14 ++++++++++----
> 4 files changed, 28 insertions(+), 16 deletions(-)
>
next prev parent reply other threads:[~2021-06-16 11:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 15:54 Stoiko Ivanov
2021-06-11 15:54 ` [pmg-devel] [PATCH pmg-api 1/2] greylisting: drop unneeded Host column form cgreylist table Stoiko Ivanov
2021-06-11 15:54 ` [pmg-devel] [PATCH pmg-api 2/2] tests: greylist: retry connecting 3 times Stoiko Ivanov
2021-06-16 11:04 ` Dominik Csapak [this message]
2021-06-16 12:21 ` [pmg-devel] applied-series: [PATCH pmg-api 0/2] remove unused greylist table column and make test_gl more robust Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6123a046-2757-e956-b201-cd0243bee6b3@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox