From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api 0/5] ruledb - improve experience for non-ascii tests and mails
Date: Mon, 14 Nov 2022 17:02:06 +0100 [thread overview]
Message-ID: <604d6ab9-26bf-308d-0072-a2a45b867ced@proxmox.com> (raw)
In-Reply-To: <20221109182728.629576-1-s.ivanov@proxmox.com>
ok tested a bit around with this series
generally "works" as in mail flows and reaches the right things
(recipient/quarantine/etc) AFAICS
some things are a bit broken:
* using notification/modify field with smtputf8 has not the desired result:
sending an email with smtputf8 and an utf8 encoded subject results in
the subject being \x "encoded", in the quarantine the notifications
and the resulting mail on delivery
(unicode characters configured in the rule themselves show properly)
ideally this would be detected and properly de/encoded
* still some issues with the statistics database
(talked to stoiko off list about that)
* the quarantine ui is rather broken with this:
neither the sender/recipient nor the mail/subject are correctly (en?)decoded
such that the utf-8 bytes are double encoded
we may want to save the info if the mail came from a 'smtputf8' source somewhere
so that we can properly de/encode the info again?
also i'm not sure if we want to release it, with the quarantine in this state.
i guess it'll be one of the first bug reports then..
What worked well:
* using unicode characters in the rule system (where appropriate):
- rule names
- rule comments
- rule values
i tested as many rules as i could find where it would make sense:
match field, attachment replacement, notify text, modify field, and so on
* sending / receiving mails with unicode characters in the sender/recipient
What's missing:
* ldap and who objects are a big one -> we should soon think about how we can do that
* statistics entries
all in all a good step in the right direction, thanks :)
prev parent reply other threads:[~2022-11-14 16:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 18:27 Stoiko Ivanov
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 1/5] ruledb: modfield: properly encode field after variable substitution Stoiko Ivanov
2022-11-11 13:56 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 2/5] ruledb: add deprecation warnings for unused actions Stoiko Ivanov
2022-11-14 16:02 ` Dominik Csapak
2022-11-15 14:32 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 3/5] fix #2541 ruledb: encode relevant values as utf-8 in database Stoiko Ivanov
2022-11-14 14:36 ` Dominik Csapak
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 4/5] ruledb: encode e-mail addresses for syslog Stoiko Ivanov
2022-11-14 14:49 ` Dominik Csapak
2022-11-09 18:27 ` [pmg-devel] [PATCH pmg-api 5/5] partially fix #2465: handle smtputf8 addresses in the rule-system Stoiko Ivanov
2022-11-14 16:03 ` Dominik Csapak
2022-11-14 16:02 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=604d6ab9-26bf-308d-0072-a2a45b867ced@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox