public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Markus Frank <m.frank@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api v3] config: adjust max_filters calculation to reflect current memory usage
Date: Wed, 21 Feb 2024 17:28:36 +0100	[thread overview]
Message-ID: <59aef2f1-851c-4592-ba22-b9567c1215f8@proxmox.com> (raw)
In-Reply-To: <20240118145532.1362939-1-m.frank@proxmox.com>

Am 18/01/2024 um 15:55 schrieb Markus Frank:
> Change max_filters calculation for systems with recommended memory
> setup (>4GB).
> 
> The values of 2816 and 150 are based on testing with 4GB, 6GB & 8GB
> memory configurations, large and small numbers of added objects and
> sending multiple mails simultaneously.
> 
> On setups with less memory, it is difficult to completely prevent OOM kills.
> So for these setups the calculation remains similar, but a warning is sent.
> 
> Related OOM killer problem found in forum:
> https://forum.proxmox.com/threads/123531/
> 
> Signed-off-by: Markus Frank <m.frank@proxmox.com>
> ---
> Tested edge cases with setting min_servers to max_servers
> in src/bin/pmg-smtp-filter
> 
>  src/PMG/Config.pm | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
>

applied, , thanks!

but I reworked the heuristic again a bit to avoid the downward glitch when
crossing the 3840 MiB boundary, old/new comparison of max_servers (the actual
count, i.e. get_max_filters() + 2):

 GiB     # max old        # max new
 0.5       5               5
 1.0       9               7
 1.5       13              8
 2.0       13              10
 2.5       17              11
 3.0       22              12
 3.5       26              13
 4.0       13              15
 4.5       16              18
 5.0       20              22
 5.5       23              25
 6.0       27              28
 6.5       30              32
 7.0       34              35
 7.5       37              39
 8.0       40              40

This should be a bit less confusing than the old one.




      parent reply	other threads:[~2024-02-21 16:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 14:55 [pmg-devel] " Markus Frank
2024-02-19 18:04 ` Alexander Zeidler
2024-02-21  8:23   ` Markus Frank
2024-02-21 16:28 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59aef2f1-851c-4592-ba22-b9567c1215f8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal