[pmg-devel] [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons

[pmg-devel] [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons

[Maximiliano Sandoval]

From a UX perspective flat buttons, i.e. buttons without a frame or
background, are not obviously clickable without an icon.

The choice of icons was taken from pve-manager's Utils.js module.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Differences from v2:
  - Use folder icon as suggest in v2 of the patch
  - Improved commit message

 js/BackupConfiguration.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/js/BackupConfiguration.js b/js/BackupConfiguration.js
index e21771f..ed9959c 100644
--- a/js/BackupConfiguration.js
+++ b/js/BackupConfiguration.js
@@ -12,11 +12,13 @@ Ext.define('PMG.BackupConfiguration', {
 	    itemId: 'local',
 	    title: gettext('Local Backup/Restore'),
 	    xtype: 'pmgBackupRestore',
+	    iconCls: 'fa fa-folder',
 	},
 	{
 	    itemId: 'proxmoxbackupserver',
 	    title: 'Proxmox Backup Server',
 	    xtype: 'pmgPBSConfig',
+	    iconCls: 'fa fa-floppy-o',
 	},
    ],
 });
-- 
2.39.2

[pmg-devel] applied: [PATCH pmg-gui v3] backup-configuration: Add icons to tab buttons

[Thomas Lamprecht]

Am 06/09/2023 um 15:09 schrieb Maximiliano Sandoval:
> From a UX perspective flat buttons, i.e. buttons without a frame or
> background, are not obviously clickable without an icon.
> 
> The choice of icons was taken from pve-manager's Utils.js module.

I amended the commit to mention the storageSchema map and change
Utils.js to PVE.Utils, as that's the module name relevant when
actually using it.

> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Differences from v2:
>   - Use folder icon as suggest in v2 of the patch
>   - Improved commit message
> 
>  js/BackupConfiguration.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!