From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui v2 2/2] disclaimer edit: add 'add-separator' checkbox
Date: Fri, 23 Feb 2024 09:02:12 +0100 [thread overview]
Message-ID: <47c8941e-945d-4196-86af-e7bf07ff5f02@proxmox.com> (raw)
In-Reply-To: <20240115111242.2781994-5-d.csapak@proxmox.com>
Am 15/01/2024 um 12:12 schrieb Dominik Csapak:
> for controlling if the separator should be included or not, default is
> on (backend default).
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> js/Utils.js | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/js/Utils.js b/js/Utils.js
> index 974df1f..4d591a7 100644
> --- a/js/Utils.js
> +++ b/js/Utils.js
> @@ -697,6 +697,12 @@ Ext.define('PMG.Utils', {
> ['start', gettext('Start')],
> ],
> },
> + {
> + xtype: 'proxmoxcheckbox',
> + name: 'add-separator',
> + fieldLabel: gettext("Add Separator"),
> + value: true,
this was missing setting the uncheckedValue to '0' explicitly, as otherwise
that value is undefined and won't get send at all if the checkbox is unchecked.
Mostly here an issue because most of the time our booleans represented by
checkboxes are opt-in, not opt-out (at least as shown to the user).
next prev parent reply other threads:[~2024-02-23 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 11:12 [pmg-devel] [PATCH pmg-api/gui/docs v2] ruledb disclaimer improvements Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-api v2 1/2] fix #2606: ruledb disclaimer: add ability to set position Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-api v2 2/2] fix #2430: ruledb disclaimer: make separator configurable Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-gui v2 1/2] disclaimer edit: add position comobobox Dominik Csapak
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-gui v2 2/2] disclaimer edit: add 'add-separator' checkbox Dominik Csapak
2024-02-23 8:02 ` Thomas Lamprecht [this message]
2024-01-15 11:12 ` [pmg-devel] [PATCH pmg-docs v2 1/1] add disclaimer position/separator docs Dominik Csapak
2024-02-23 8:01 ` [pmg-devel] applied-series: [PATCH pmg-api/gui/docs v2] ruledb disclaimer improvements Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47c8941e-945d-4196-86af-e7bf07ff5f02@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox