From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] applied: [PATCH yew-comp 1/1] login panel: make realm selector optional
Date: Thu, 23 Oct 2025 08:54:36 +0200 [thread overview]
Message-ID: <4430db4d-4b7a-4483-96d1-e8387be70746@proxmox.com> (raw)
In-Reply-To: <176115256113.3083975.11905428400395729105.b4-ty@proxmox.com>
On 10/22/25 7:04 PM, Thomas Lamprecht wrote:
> On Wed, 15 Oct 2025 16:22:59 +0200, Dominik Csapak wrote:
>> in some cases, we don't want to have a realm selector because the user
>> has to enter e.g. an e-mail address instead (like the PMG mobile
>> quarantine gui).
>>
>> Add a property for that that defaults to the current behavior and add a
>> validator for the username field that checks for an '@' in the middle.
>>
>> [...]
>
> Applied but on top of Shannon's patches for which I had to solve some merge
> conflict, so would be great if you could recheck the changes, thanks!
FYI: changes look good to me and tests fine here
>
> [1/1] login panel: make realm selector optional
> commit: 54c57fae4ce1e9db0b87faed02e46e3b5fa43a2f
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-10-23 6:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 14:22 [pmg-devel] [PATCH pmg-yew-quarantine-gui/proxmox/yew-comp 0/3] fix ldap login for pmg mobile quarantine Dominik Csapak
2025-10-15 14:22 ` [pmg-devel] [PATCH proxmox 1/1] login: fix userid check for '@quarantine' user tickets Dominik Csapak
2025-10-21 18:33 ` [pmg-devel] applied: " Thomas Lamprecht
2025-10-15 14:22 ` [pmg-devel] [PATCH yew-comp 1/1] login panel: make realm selector optional Dominik Csapak
2025-10-22 17:03 ` [pmg-devel] applied: " Thomas Lamprecht
2025-10-23 6:54 ` Dominik Csapak [this message]
2025-10-15 14:23 ` [pmg-devel] [PATCH pmg-yew-quarantine-gui 1/1] login page: disable realm selection Dominik Csapak
2025-10-22 17:35 ` [pmg-devel] applied: " Thomas Lamprecht
2025-10-20 15:03 ` [pmg-devel] [PATCH pmg-yew-quarantine-gui/proxmox/yew-comp 0/3] fix ldap login for pmg mobile quarantine Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4430db4d-4b7a-4483-96d1-e8387be70746@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox