From: Mira Limbeck <m.limbeck@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api v8 7/13] api: users: create user with a specified realm
Date: Wed, 26 Feb 2025 17:29:24 +0100 [thread overview]
Message-ID: <4332f00b-9473-4942-8617-481fb2fe2014@proxmox.com> (raw)
In-Reply-To: <57120e9b-e246-4385-a01f-89a66e33aac1@proxmox.com>
On 2/26/25 16:36, Mira Limbeck wrote:
> On 2/26/25 15:07, Markus Frank wrote:
>> Signed-off-by: Markus Frank <m.frank@proxmox.com>
>> ---
>> v8: fixed "Use of uninitialized value in string" when realm is not set
>> at user creation
>>
>> src/PMG/API2/Users.pm | 3 +++
>> src/PMG/UserConfig.pm | 1 -
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/PMG/API2/Users.pm b/src/PMG/API2/Users.pm
>> index 42c82b7..f137b87 100644
>> --- a/src/PMG/API2/Users.pm
>> +++ b/src/PMG/API2/Users.pm
>> @@ -111,6 +111,9 @@ __PACKAGE__->register_method ({
>> die "User '$param->{userid}' already exists\n"
>> if $cfg->{$param->{userid}};
>>
>> + die "Currently you cannot create user in the PAM realm\n"
>> + if $param->{realm} && $param->{realm} eq 'pam';
>> +
> the warning no longer shows, but you can still create a user for `pam`
> by just specifying the userid:
> ```
> pmg:/access/users> create --role audit --userid test123@pam
> 200 OK
> ```
api2/json/access/users returns the `realm` as a separate field. it is
extracted by splitting the userid on the first '@'. see
PMG/UserConfig.pm -> read_user_conf
maybe we could use this here as well via a helper sub in UserConfig.pm?
>
>
>
>> my $entry = {};
>> foreach my $k (keys %$param) {
>> my $v = $param->{$k};
>> diff --git a/src/PMG/UserConfig.pm b/src/PMG/UserConfig.pm
>> index fe6d2c8..9a6f142 100644
>> --- a/src/PMG/UserConfig.pm
>> +++ b/src/PMG/UserConfig.pm
>> @@ -141,7 +141,6 @@ my $schema = {
>>
>> our $create_schema = clone($schema);
>> delete $create_schema->{properties}->{username};
>> -delete $create_schema->{properties}->{realm};
>> $create_schema->{properties}->{password} = {
>> description => "Password",
>> type => 'string',
>
>
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
>
>
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-02-26 16:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 14:07 [pmg-devel] [PATCH perl-rs/pmg-api/widget-toolkit/pmg-gui v8 0/13] fix #3892: OpenID Connect Markus Frank
2025-02-26 14:07 ` [pmg-devel] [PATCH proxmox-perl-rs v8 1/13] move openid code from pve-rs to common Markus Frank
2025-02-26 16:57 ` [pmg-devel] applied: " Thomas Lamprecht
2025-02-26 14:07 ` [pmg-devel] [PATCH proxmox-perl-rs v8 2/13] remove empty PMG::RS::OpenId package to avoid confusion Markus Frank
2025-02-26 16:58 ` [pmg-devel] applied: " Thomas Lamprecht
2025-02-26 17:55 ` [pmg-devel] " Stoiko Ivanov
2025-02-26 14:07 ` [pmg-devel] [PATCH pmg-api v8 3/13] config: add plugin system for authentication realms Markus Frank
2025-02-26 14:40 ` Stoiko Ivanov
2025-02-26 14:07 ` [pmg-devel] [PATCH pmg-api v8 4/13] config: add oidc type authentication realm Markus Frank
2025-02-26 14:07 ` [pmg-devel] [PATCH pmg-api v8 5/13] api: add/update/remove authentication realms like in PVE Markus Frank
2025-02-26 14:07 ` [pmg-devel] [PATCH pmg-api v8 6/13] api: oidc login similar to PVE Markus Frank
2025-02-26 14:41 ` Stoiko Ivanov
2025-02-26 14:07 ` [pmg-devel] [PATCH pmg-api v8 7/13] api: users: create user with a specified realm Markus Frank
2025-02-26 15:36 ` Mira Limbeck
2025-02-26 16:29 ` Mira Limbeck [this message]
2025-02-26 14:07 ` [pmg-devel] [PATCH widget-toolkit v8 08/13] fix: window: AuthEditBase: rename variable 'realm' to 'type' Markus Frank
2025-02-26 17:52 ` [pmg-devel] partially-applied-series: " Thomas Lamprecht
2025-02-26 14:07 ` [pmg-devel] [PATCH widget-toolkit v8 09/13] panel: AuthView: change API path in pmx-domains model Markus Frank
2025-02-26 14:07 ` [pmg-devel] [PATCH widget-toolkit v8 10/13] form: RealmComboBox: add option to change the API path Markus Frank
2025-02-26 14:07 ` [pmg-devel] [PATCH pmg-gui v8 11/13] login: add option to login with OIDC realm Markus Frank
2025-02-26 14:07 ` [pmg-devel] [PATCH pmg-gui v8 12/13] add realms panel to user management Markus Frank
2025-02-26 14:07 ` [pmg-devel] [PATCH pmg-gui v8 13/13] user: add realm field for user creation Markus Frank
2025-02-26 20:17 ` [pmg-devel] applied: [PATCH perl-rs/pmg-api/widget-toolkit/pmg-gui v8 0/13] fix #3892: OpenID Connect Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4332f00b-9473-4942-8617-481fb2fe2014@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal