From: Friedrich Weber <f.weber@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api/pmg-gui v3]
Date: Wed, 19 Feb 2025 17:47:03 +0100 [thread overview]
Message-ID: <41ea07e7-7737-47cf-b4b7-00a453716dcc@proxmox.com> (raw)
In-Reply-To: <20250219121851.110090-1-s.ivanov@proxmox.com>
Thanks for the v3!
On 19/02/2025 13:18, Stoiko Ivanov wrote:
> This series replaces two previous patch-series.
>
> v2->v3:
> for the content-type matching based on magic infromation only two patches
> were added that remove the fallback on the content-type header in case no
> filetype could be found through magic.
> The one place were I decided to fall back on header information was when
> determining if a mime-part is an archive.
>
> places where the content-type information was used are based on grepping
> for PMX_ in the pmg-api sources.
>
> Tested with Friedrich's swaks reproducer - the random blob was not
> detected as pdf anymore.
I tested this again with the reproducer from v2 -- seems to work as I'd
expect now!
> no changes to the series for matching headers only on the top-part
> (resending so that the comment that it's based on v2 of the content-type
> series does not cause confusion)
I also tested the `top-part-only` option, works as I'd expect.
One nit for 3/5 sent separately, apart from that I didn't encounter any
issues:
Tested-by: Friedrich Weber <f.weber@proxmox.com>
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2025-02-19 16:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 12:18 Stoiko Ivanov
2025-02-19 12:18 ` [pmg-devel] [PATCH pmg-api v3 1/5] ruledb: disclaimer: simplify update-case Stoiko Ivanov
2025-02-19 12:18 ` [pmg-devel] [PATCH pmg-api v3 2/5] utils: content-type: don't fallback to header information for magic Stoiko Ivanov
2025-02-19 12:18 ` [pmg-devel] [PATCH pmg-api v3 3/5] pmg-smtp-filter: archive-detection: use header information as well Stoiko Ivanov
2025-02-19 16:47 ` Friedrich Weber
2025-02-20 15:21 ` Dominik Csapak
2025-02-20 16:19 ` Stoiko Ivanov
2025-02-19 12:18 ` [pmg-devel] [PATCH pmg-api v3 4/5] ruledb: content-type: add flag for matching only based on magic/content Stoiko Ivanov
2025-02-19 12:18 ` [pmg-devel] [PATCH pmg-api v3 5/5] fix #2709: ruledb: match-field: optionally restrict to top mime-part Stoiko Ivanov
2025-02-19 12:18 ` [pmg-devel] [PATCH pmg-gui v3 1/3] rules/object: remove icon from remove button Stoiko Ivanov
2025-02-19 12:18 ` [pmg-devel] [PATCH pmg-gui v3 2/3] rules/content-typefilter: add checkbox for file content only matching Stoiko Ivanov
2025-02-19 12:18 ` [pmg-devel] [PATCH pmg-gui v3 3/3] fix #2709: rules: match-field: add top-level-only checkbox Stoiko Ivanov
2025-02-19 16:47 ` Friedrich Weber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ea07e7-7737-47cf-b4b7-00a453716dcc@proxmox.com \
--to=f.weber@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal