From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api 2/2] ruledb: content-type: do not rely on PMX_header_ct
Date: Tue, 25 Feb 2025 11:09:54 +0100 [thread overview]
Message-ID: <3c7cd317-cfc1-403d-933b-a52a2f4b001b@proxmox.com> (raw)
In-Reply-To: <20250224210728.378493-3-s.ivanov@proxmox.com>
just for the record, this fixes failing regression test for me too.
as discussed off-list, with this change i think we can drop the 'PMX_header_ct' helper variable
completely since the only place where we check this again is once in 'unpack_entity' and there we
have access to the content type anyway.
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2025-02-25 10:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 21:07 [pmg-devel] [PATCH pmg-api 0/2] fix content-type matching for parts without bodyhandle Stoiko Ivanov
2025-02-24 21:07 ` [pmg-devel] [PATCH pmg-api 1/2] ruledb: content-type: drop unreachable fallback for only_content Stoiko Ivanov
2025-02-24 21:07 ` [pmg-devel] [PATCH pmg-api 2/2] ruledb: content-type: do not rely on PMX_header_ct Stoiko Ivanov
2025-02-25 10:09 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c7cd317-cfc1-403d-933b-a52a2f4b001b@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal