From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Leo Nunner <l.nunner@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api/gui/docs, proxmox-widget-toolkit] Extend rule system
Date: Tue, 11 Apr 2023 13:19:38 +0200 [thread overview]
Message-ID: <35e92248-8cbc-f986-8ec9-50ee55ba1d89@proxmox.com> (raw)
In-Reply-To: <a1e0810c-8b4e-da56-ca3e-94e90cf9857d@proxmox.com>
Am 11/04/2023 um 13:04 schrieb Leo Nunner:
> On 2023-04-11 11:52, Thomas Lamprecht wrote:
>> For now some higher level review inline from my side, not sure if I get to
>> a more in-depth for each patch soonish.
>>
>> Am 07/04/2023 um 15:42 schrieb Leo Nunner:
>>> This series introduces two new features for the PMG rule system: object
>>> negation, and match groups. Negation allows the user to negate objects
>>> inside a rule, meaning that they will evaluate to true if their
>>> condition is NOT fulfilled.
>> Do we really don't have any test system for the rule system, if that'd be some
>> technical debt to address probably rather sooner than later.
> We have regression tests for PMG, which should already cover this AFAIK.
Yeah I know of those regression tests, but a lot of the rule system would
not require a (postgres) DB to be spun up, but could often run on a higher
level, e.g., by mocking the higher level methods; iow. more like integrated
test that, while covering a smaller/more specific surface area, can be hosted
in the pmg-api repo directly and run on every package build, vs. the more
complex integration regression test suite that also contains some possibly
sensible material. I mean, the existing regression tests are half-way between
some suite that tests explicitly the external API/mail-transports endpoints only
and some internal testing done.
Also, you nobody mention that you have added, or will add, explicit tests for
the new features ;-)
>>> The second feature, match groups, allows objects to be chained together.
>>> A match group functions as a container for multiple other objects; it
>>> will only evaluate to true if all its members evaluate to true. Match groups
>>> are connected via logical 'or' to all other objects inside the rule;
>>> take the following rule system:
>>>
>>> - Rule
>>> - Match Group
>>> - Object 1
>>> - Object 2
>>> - Object 3
>>>
>>> It will match if either (Object 1 && Object 2), or if Object 3
>>> evaluate to true.
>> Why not allow or matches? Most mail filter tools (like e.g., the x-sieve
>> fronted of open-xchange) allow to configure if all or any of a group's matching
>> rules must trigger for the whole group to be true.
>>
>> I mean, OR matching can be workarounded by duplicated rules but if we add
>> groups with AND combination, then OR is something that I'd think is also
>> expected to be there.
> Not sure if I follow…
>
> - Rule
> - Who Objects
> - Object 1
> - When Objects
> - Object 2
>
> You would want something like this to match if either Who *or* When
> produce a match? IIRC those are connected via AND right now.
I hab more a switch for the "Match Group" in mind, i.e., to configure if it
should act as and, or as or. But, tbf, I did not worked with the PMG rule
system that closely in recent times – maybe I'm just missing something here.
prev parent reply other threads:[~2023-04-11 11:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 13:42 Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-api 1/8] feature: negation: add field to database Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-api 2/8] feature: negation: parse negation value into objects Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-api 3/8] feature: negation: expand/implement API endpoints Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-api 4/8] feature: negation: implement matching logic Leo Nunner
2023-04-11 7:35 ` Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-api 5/8] feature: match groups: add field to database Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-api 6/8] feature: match groups: parse field into objects Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-api 7/8] feature: match groups: update API endpoints Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-api 8/8] feature: match groups: implement matching logic Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-gui 1/2] feature: negate objects inside rules Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-gui 2/2] feature: introduce logical 'and' for rules Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH pmg-docs] docs: document negation and match groups Leo Nunner
2023-04-07 13:42 ` [pmg-devel] [PATCH widget-toolkit] dark-mode: fix colour of default tree icons Leo Nunner
2023-04-11 9:52 ` [pmg-devel] [PATCH pmg-api/gui/docs, proxmox-widget-toolkit] Extend rule system Thomas Lamprecht
2023-04-11 11:04 ` Leo Nunner
2023-04-11 11:19 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35e92248-8cbc-f986-8ec9-50ee55ba1d89@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox