From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] ruledb: modfield: properly handle fields spanning multiple lines
Date: Tue, 15 Nov 2022 15:32:18 +0100 [thread overview]
Message-ID: <35bd574a-061e-d35f-3dc4-94fde23ba1b4@proxmox.com> (raw)
In-Reply-To: <20221115124014.63658-1-s.ivanov@proxmox.com>
Am 15/11/2022 um 13:40 schrieb Stoiko Ivanov:
> this commit fixes aa3a005a5e7e3ad69ed35e9957fa514f73315c72
>
> MIME::Words::encode_mimewords does not deal with multiline headers
> (the warning about this being a 'quick and dirty' solution [0]
> partially tells as much).
>
> Instead - split the replacement value after variable substition on:
> '\r?\n\s*' (to capture multi-line values like __SPAM_INFO__, but also
> already folded headers, which are separated by '\r?\n\s+') and do the
> substitution for each line seperately.
>
> reported in our community forum:
> https://forum.proxmox.com/threads/.118001/
>
> [0] https://metacpan.org/pod/MIME::Words#PUBLIC-INTERFACE
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/PMG/RuleDB/ModField.pm | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
>
applied, with Dominik's T-b & R-b, thanks!
prev parent reply other threads:[~2022-11-15 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 12:40 [pmg-devel] " Stoiko Ivanov
2022-11-15 14:22 ` Dominik Csapak
2022-11-15 14:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35bd574a-061e-d35f-3dc4-94fde23ba1b4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox