From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api/gui/docs v2] small improvments for PBS integration
Date: Fri, 5 Mar 2021 23:07:51 +0100 [thread overview]
Message-ID: <337b8892-5680-073e-0906-973f9c205ab0@proxmox.com> (raw)
In-Reply-To: <20210301141225.18394-1-s.ivanov@proxmox.com>
On 01.03.21 15:12, Stoiko Ivanov wrote:
> v2->v1:
> * addressed Thomas great feedback!:
> ** reordered the patches (the prevention of the race for concurrent
> pbs-backup is not before the notification feature)
> ** concurrent pbs-backups now simply use a backup-tmpdir indexed by
> remote+pid+time instead of locking.
> ** printing and exiting on error now happen as before (instead of being delayed)
> ** default is 'never' (instead of the unclear mix of 'error' in the schema
> and 'never' in the code
> ** not having an admin-email configured is treated as warning.
>
> original cover-letter for v1:
> This patchset addresses #3146 and #3154.
> Additionally I added patches for small cosmetic cleanups, and a fix
> for concurrent pbs-backups (they raced with each other during my tests)
>
> patch 1/4 for pmg-gui depends on an updated pmg-docs-generator for building
> (and on an updated pmg-docs for linking to the correct section)
>
> pmg-api:
> Stoiko Ivanov (3):
> backup: pbs: prevent race in concurrent backups
> backup: fix #3146 add email notifications
> backup: add notify parameter to 'classic' backup
>
> src/Makefile | 1 +
> src/PMG/API2/Backup.pm | 23 +++++++++++--
> src/PMG/API2/PBS/Job.pm | 50 +++++++++++++++++++++-------
> src/PMG/Backup.pm | 35 +++++++++++++++++++
> src/PMG/PBSConfig.pm | 7 ++++
> src/templates/backup-notification.tt | 19 +++++++++++
> 6 files changed, 120 insertions(+), 15 deletions(-)
> create mode 100644 src/templates/backup-notification.tt
>
> pmg-gui:
> Stoiko Ivanov (4):
> backup: pbs: add onlineHelp anchors
> backup: fix #3154: make statistic backup optional
> backup: pbs: fix #3154: add statistic setting to remote
> backup: pbs: fix #3146 add notify setting to remote
>
> js/BackupRestore.js | 45 ++++++++++++++++++++++++++++---------------
> js/PBSConfig.js | 1 +
> js/PBSRemoteEdit.js | 20 +++++++++++++++++++
> js/PBSSnapshotView.js | 19 +++---------------
> 4 files changed, 53 insertions(+), 32 deletions(-)
>
> pmg-docs:
> Stoiko Ivanov (1):
> backup: shortly document #3146 and #3154
>
> pmgbackup.adoc | 4 ++++
> 1 file changed, 4 insertions(+)
>
applied now also the remaining patches, thanks!
prev parent reply other threads:[~2021-03-05 22:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 14:12 [pmg-devel] " Stoiko Ivanov
2021-03-01 14:12 ` [pmg-devel] [PATCH pmg-api v2 1/3] backup: pbs: prevent race in concurrent backups Stoiko Ivanov
2021-03-05 21:42 ` [pmg-devel] applied: " Thomas Lamprecht
2021-03-01 14:12 ` [pmg-devel] [PATCH pmg-api v2 2/3] backup: fix #3146 add email notifications Stoiko Ivanov
2021-03-05 21:43 ` [pmg-devel] applied: " Thomas Lamprecht
2021-03-01 14:12 ` [pmg-devel] [PATCH pmg-api v2 3/3] backup: add notify parameter to 'classic' backup Stoiko Ivanov
2021-03-05 21:43 ` [pmg-devel] applied: " Thomas Lamprecht
2021-03-01 14:12 ` [pmg-devel] [PATCH pmg-gui v2 1/4] backup: pbs: add onlineHelp anchors Stoiko Ivanov
2021-03-01 14:12 ` [pmg-devel] [PATCH pmg-gui v2 2/4] backup: fix #3154: make statistic backup optional Stoiko Ivanov
2021-03-01 14:12 ` [pmg-devel] [PATCH pmg-gui v2 3/4] backup: pbs: fix #3154: add statistic setting to remote Stoiko Ivanov
2021-03-01 14:12 ` [pmg-devel] [PATCH pmg-gui v2 4/4] backup: pbs: fix #3146 add notify " Stoiko Ivanov
2021-03-01 14:12 ` [pmg-devel] [PATCH pmg-docs v2 1/1] backup: shortly document #3146 and #3154 Stoiko Ivanov
2021-03-05 21:45 ` [pmg-devel] applied: " Thomas Lamprecht
2021-03-05 22:07 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=337b8892-5680-073e-0906-973f9c205ab0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox