From: Daniel Berteaud <daniel@firewall-services.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api 1/1] [pmg-api]: fix #3098 : first check for exact domain match
Date: Tue, 27 Oct 2020 12:46:11 +0100 (CET) [thread overview]
Message-ID: <335488398.2528.1603799171114.JavaMail.zimbra@fws.fr> (raw)
In-Reply-To: <20201027123901.0117e0a5@rosa.proxmox.com>
----- Le 27 Oct 20, à 12:39, Stoiko Ivanov s.ivanov@proxmox.com a écrit :
> Hi,
>
> Thank you very much for catching this, opening a report and directly
> providing a patch!
>
> The patch works as advertised (gave it a quick spin on my test-setup).
>
> However I wonder if it wouldn't be better to address this by sorting
> properly - instead of differentiating between exact match and first
> matching subdomain we could match for the longest matching subdomain
> (suggestion inline).
> This should cover your issue as well as far as I can tell, and provide
> fewer suprises regarding the chosen signing domain.
>
> What do you think?
I'll give your proposal a try and report back (my perl sort-fu is a bit rusty :-) )
Cheers,
Daniel
--
[ https://www.firewall-services.com/ ]
Daniel Berteaud
FIREWALL-SERVICES SAS, La sécurité des réseaux
Société de Services en Logiciels Libres
Tél : +33.5 56 64 15 32
Matrix: @dani:fws.fr
[ https://www.firewall-services.com/ | https://www.firewall-services.com ]
prev parent reply other threads:[~2020-10-27 11:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 10:50 [pmg-devel] [PATCH pmg-api 0/1] DKIM, " Daniel Berteaud
2020-10-26 10:50 ` [pmg-devel] [PATCH pmg-api 1/1] [pmg-api]: fix #3098 : " Daniel Berteaud
2020-10-27 11:39 ` Stoiko Ivanov
2020-10-27 11:46 ` Daniel Berteaud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=335488398.2528.1603799171114.JavaMail.zimbra@fws.fr \
--to=daniel@firewall-services.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox