public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied-series: Re: [PATCH pmg-gui v2 0/2] low-hanging improvments for the quarantine interface
Date: Fri, 28 Oct 2022 11:35:42 +0200	[thread overview]
Message-ID: <32804fcf-845b-a8d9-0625-588b35e2e27e@proxmox.com> (raw)
In-Reply-To: <20221027191258.11594-1-s.ivanov@proxmox.com>

On 27/10/2022 21:12, Stoiko Ivanov wrote:
> v1->v2:
> * dropped already applied patches
> * changed the patches, by splitting the refactoring of the spamquarantine
>   in a patch of its own, and changing virus and attachmentquarantine in
>   the second patch (no functional change intended) - big thanks for the
>   suggestion @Thomas!!
> 
> gave me also the chance to see the adaptations of the icon-colors for delivery
> and delete by Thomas in action - I like it!
> 
> original cover-letter for v1:
> A few bugzilla entries ask for features in the quarantine interface that
> seem quite sensible (e.g. #4137), or are already present in the (by far
> more used) spamquarantine, but never made it to the others.
> 
> This patchset contains a single small fix, and a refactoring of the
> quarantine views to use the same controller.
> 
> Would be grateful for feedback
> 
> 
> Stoiko Ivanov (2):
>   quarantine: refactor spamquarantine controller
>   quarantine: use new controller for virus and attachment quarantines
> 
>  js/AttachmentQuarantine.js            | 113 +++++-----
>  js/Makefile                           |   1 +
>  js/SpamQuarantine.js                  | 290 +++++++++-----------------
>  js/VirusQuarantine.js                 |  86 ++------
>  js/controller/QuarantineController.js | 170 +++++++++++++++
>  5 files changed, 335 insertions(+), 325 deletions(-)
>  create mode 100644 js/controller/QuarantineController.js
> 


applied series, many thanks!




      parent reply	other threads:[~2022-10-28  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 19:12 [pmg-devel] " Stoiko Ivanov
2022-10-27 19:12 ` [pmg-devel] [PATCH pmg-gui v2 1/2] quarantine: refactor spamquarantine controller Stoiko Ivanov
2022-10-27 19:12 ` [pmg-devel] [PATCH pmg-gui v2 2/2] quarantine: use new controller for virus and attachment quarantines Stoiko Ivanov
2022-10-28  9:35 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32804fcf-845b-a8d9-0625-588b35e2e27e@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal