Re: [pmg-devel] [PATCH pmg-gui 1/2] disclaimer edit: add 'top' checkbox

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 09/01/2024 um 14:59 schrieb Dominik Csapak:
> to enable adding the disclaimer on top
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  js/Utils.js | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/js/Utils.js b/js/Utils.js
> index 7fa154e..daf0934 100644
> --- a/js/Utils.js
> +++ b/js/Utils.js
> @@ -686,6 +686,11 @@ Ext.define('PMG.Utils', {
>  		    growMax: 250,
>  		    fieldLabel: gettext("Disclaimer"),
>  		},
> +		{
> +		    xtype: 'proxmoxcheckbox',
> +		    name: 'top',
> +		    fieldLabel: gettext("On Top"),

This is IMO not really telling due to missing context.

While one could just change the label, that still wouldn't convey
the actual default position.

So, maybe using a "position" combobox (or radio-group, to reduce
required clicks) selection between "bottom" and "top" would
provide better UX here?

btw. this series seems to miss a (small) docs adaption to the
5.1.8. Disclaimer section.