From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-gui 1/2] disclaimer edit: add 'top' checkbox
Date: Fri, 12 Jan 2024 17:00:27 +0100 [thread overview]
Message-ID: <2ed8c7fc-0557-4a63-9752-bcecaa3c7e50@proxmox.com> (raw)
In-Reply-To: <20240109135906.66200-6-d.csapak@proxmox.com>
Am 09/01/2024 um 14:59 schrieb Dominik Csapak:
> to enable adding the disclaimer on top
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> js/Utils.js | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/js/Utils.js b/js/Utils.js
> index 7fa154e..daf0934 100644
> --- a/js/Utils.js
> +++ b/js/Utils.js
> @@ -686,6 +686,11 @@ Ext.define('PMG.Utils', {
> growMax: 250,
> fieldLabel: gettext("Disclaimer"),
> },
> + {
> + xtype: 'proxmoxcheckbox',
> + name: 'top',
> + fieldLabel: gettext("On Top"),
This is IMO not really telling due to missing context.
While one could just change the label, that still wouldn't convey
the actual default position.
So, maybe using a "position" combobox (or radio-group, to reduce
required clicks) selection between "bottom" and "top" would
provide better UX here?
btw. this series seems to miss a (small) docs adaption to the
5.1.8. Disclaimer section.
next prev parent reply other threads:[~2024-01-12 16:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 13:59 [pmg-devel] [PATCH pmg-api/gui] ruledb disclaimer improvements Dominik Csapak
2024-01-09 13:59 ` [pmg-devel] [PATCH pmg-api 1/4] ruledb disclaimer: cleanup trailing whitespace Dominik Csapak
2024-01-12 15:47 ` [pmg-devel] applied: " Thomas Lamprecht
2024-01-09 13:59 ` [pmg-devel] [PATCH pmg-api 2/4] ruledb disclaimer: if/elsif code cleanup Dominik Csapak
2024-01-12 15:47 ` [pmg-devel] applied: " Thomas Lamprecht
2024-01-09 13:59 ` [pmg-devel] [PATCH pmg-api 3/4] fix #2606: ruledb disclaimer: add ability to add on top Dominik Csapak
2024-01-09 13:59 ` [pmg-devel] [PATCH pmg-api 4/4] fix #2430: ruledb disclaimer: make separator configurable Dominik Csapak
2024-01-09 13:59 ` [pmg-devel] [PATCH pmg-gui 1/2] disclaimer edit: add 'top' checkbox Dominik Csapak
2024-01-12 16:00 ` Thomas Lamprecht [this message]
2024-01-09 13:59 ` [pmg-devel] [PATCH pmg-gui 2/2] disclaimer edit: add 'add-separator' checkbox Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ed8c7fc-0557-4a63-9752-bcecaa3c7e50@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox