From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] restenv: pass arguments to check_node_is_master
Date: Thu, 27 Feb 2025 14:59:37 +0100 [thread overview]
Message-ID: <2e4175a7-f1f2-4fd0-93c5-4b184d63dfc3@proxmox.com> (raw)
In-Reply-To: <20250227134545.687525-1-s.ivanov@proxmox.com>
Am 27.02.25 um 14:45 schrieb Stoiko Ivanov:
> Mira noticed this while testing logging in to a secondary node with
> OIDC and autocreate.
>
> as check_node_is_master is only used in one other place (without
> $noerr) I assume this simply never got noticed.
>
> Reported-by: Mira Limbeck <m.limbeck@proxmox.com>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> src/PMG/RESTEnvironment.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
reworded subject to "query arguments in check_node_is_master",
as the problem wasn't that call-sites forgot to pass the argument
but that the method did not look (queried) at them.
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2025-02-27 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 13:45 [pmg-devel] " Stoiko Ivanov
2025-02-27 13:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e4175a7-f1f2-4fd0-93c5-4b184d63dfc3@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal