From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-gui 3/5] fix #4238: SpamInfoGrid: enable sorting & add colors for spam score
Date: Mon, 7 Nov 2022 10:56:50 +0100 [thread overview]
Message-ID: <2ca5ead5-06e8-2d29-517e-b942fc01b51e@proxmox.com> (raw)
In-Reply-To: <20221104150425.124194-5-d.csapak@proxmox.com>
Am 04/11/2022 um 16:04 schrieb Dominik Csapak:
> sorting the matching spam rules, e.g. by score, makes it easier to see
> which rules have more weight in determining spam.
>
> Additionally, color code the scores with colors akin to the rationale
> in commit:
> 365f84c ("quarantines: color code deliver and delete buttons")
>
> (red for positive spam scores, blue for negative ones)
>
> and increase the font-weight for large spamscore contributing rules.
>
> i chose a different blue tone that is more muted than what we use in
> 'info-blue' but is different from both the 'hover' color and the
> 'selected' color
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> while the bug mentions that colors are problematic, there are not enough
> font-weights to properly convey what we want to show here, so i added
> colors with the same rationale we already used for the deliver/delete
> buttons
>
> js/SpamInfoGrid.js | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
>
applied, thanks! with some further gradients and a switch to monospace
for the value and spam level names (unrelated to the report, so mentioning
it for completeness sake)
next prev parent reply other threads:[~2022-11-07 9:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-04 15:04 [pmg-devel] [PATCH pmg-api/pmg-gui] improvements to the quarantine interface Dominik Csapak
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-api 1/1] api/quarantine: allow 'listattachments' for quarantine users Dominik Csapak
2022-11-07 8:47 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-gui 1/5] simply quarantine controllers a bit Dominik Csapak
2022-11-07 8:47 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-gui 2/5] quarantines: add attachment grid to spam and virus quarantine Dominik Csapak
2022-11-07 12:21 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-gui 3/5] fix #4238: SpamInfoGrid: enable sorting & add colors for spam score Dominik Csapak
2022-11-07 9:56 ` Thomas Lamprecht [this message]
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-gui 4/5] quarantine: improve borders for docked items Dominik Csapak
2022-11-07 9:57 ` [pmg-devel] applied: " Thomas Lamprecht
2022-11-04 15:04 ` [pmg-devel] [PATCH pmg-gui 5/5] fix #2533: quarantine: add overflowHandler to the preview panel Dominik Csapak
2022-11-07 9:57 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ca5ead5-06e8-2d29-517e-b942fc01b51e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox