Re: [pmg-devel] [PATCH pmg-api v2 0/2] fix #2795 - add DSN support

[Dominik Csapak <d.csapak@proxmox.com>]

LGTM

Tested with after/before queue with and withoud dsn
(got a dsn reply everytime i expected it)

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>

On 11/25/21 13:03, Stoiko Ivanov wrote:
> v1->v2:
> * incorporated Dominik's feedback - huge thanks!!
> * all parameters we don't care about are ignored (as before)
> * the options are not transformed into lowercase unconditionally anymore
>    (they contain mail-addresses, and mail-ids - which are not case-insensitive)
> * split up the patch into 2 commits - since the regexes for the MAIL and
>    RCPT commands is more sensitive than I expected:
> ** read up on allowed characters in local-parts - tried extending the regex
>     to parse mailboxes more correctly - failed at that
> ** decided it's ok to not allow '>' in localparts (we did not do so before)
> ** did quite a bit more testing thanks to that
> 
> 
> Stoiko Ivanov (2):
>    partially fix #2795: allow for '>' in smtp parameters
>    fix #2795: add support for DSN
> 
>   src/PMG/RuleDB/Accept.pm |  2 +-
>   src/PMG/RuleDB/BCC.pm    |  6 +++++-
>   src/PMG/SMTP.pm          | 27 ++++++++++++++++++++++-----
>   src/PMG/Utils.pm         | 19 ++++++++++++++++---
>   src/bin/pmg-smtp-filter  |  1 +
>   5 files changed, 45 insertions(+), 10 deletions(-)
>