From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-gui v3] fix #4510: add filter box to many grids
Date: Wed, 21 Feb 2024 18:10:11 +0100 [thread overview]
Message-ID: <230e1501-79b3-4bdc-bfa5-6c9200f69905@proxmox.com> (raw)
In-Reply-To: <20240221144744.3850083-1-d.csapak@proxmox.com>
Am 21/02/2024 um 15:47 schrieb Dominik Csapak:
> namely relay domains, transports, trusted networks, smtp whitelist +
> when/what/who object grids.
>
> Adds a new 'FilterField', that takes a store and a list of columns to
> filter, and filters on every change.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v3:
> * always clear the old filters on the store when the value changes
> otherwise we only add filter but never remove them
>
> js/Makefile | 1 +
> js/MyNetworks.js | 5 ++++
> js/ObjectGroup.js | 11 ++++++++
> js/RelayDomains.js | 5 ++++
> js/Transport.js | 5 ++++
> js/form/FilterField.js | 57 ++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 84 insertions(+)
> create mode 100644 js/form/FilterField.js
>
>
applied, thanks!
One could argue though that having these for action object might be good
for consistency w.r.t. the other object types.
And even though most setups probably has not _that_ many of those, it has
almost no cost and might be even nice on to find stuff when one has low
count of actions.
Similar for the mail filter rule grid, but no hard feelings for either.
prev parent reply other threads:[~2024-02-21 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 14:47 [pmg-devel] " Dominik Csapak
2024-02-21 14:57 ` Mira Limbeck
2024-02-21 17:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=230e1501-79b3-4bdc-bfa5-6c9200f69905@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox