From: Dominik Csapak <d.csapak@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-docs 2/2] administration: add section for statistics
Date: Mon, 27 Mar 2023 13:59:26 +0200 [thread overview]
Message-ID: <2203c1a7-20e7-eea2-6400-a8e3675ca5bb@proxmox.com> (raw)
In-Reply-To: <20230327133231.73cb0f14@rosa.proxmox.com>
On 3/27/23 13:32, Stoiko Ivanov wrote:
> Thanks for addressing this - This should make the experience for our users
> much better, and reduce quite a few support-requests!
>
> In general it looks good to me and could be merged as is
>
> One high-level suggestion and a few nits inline (could be a follow-up as
> well):
>
> Since Statistics is its own entry in the GUI's navigation tree - why not
> have it as a dedicated chapter of the docs? (quickly tried it here - just
> putting it in a file of its own, and raising the heading levels by one
> (`-` -> `=`, `~` -> `-`) and including it in pmg-adminstration-guide.adoc
> seems to work fine)
>
> It's not a strict necessity, and the docs to GUI matching is not 100%
> currently either (Backup/Restore is its own chapter, but under
> Configuration on the GUI for example)
>
> Let me know what you think (and if you'll find the time soon to address it
> or if I should send the suggestions as follow-up)
>
thanks for the review, the inline changes all make sense and i'll send a v2 shortly
as for the own chapter, it don't really have a preference here. i put
it into administration as i did not have the impression that
the amount of information would warrant it's own chapter.
from a user perspective though, it would probably better as it's own
chapter, since it's also separate in the gui as you mentioned
so i'll do that in the v2
prev parent reply other threads:[~2023-03-27 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 13:30 [pmg-devel] [PATCH pmg-api/docs] improve documentation Dominik Csapak
2023-03-24 13:30 ` [pmg-devel] [PATCH pmg-api 1/1] config: extend documentation for options a bit Dominik Csapak
2023-03-26 15:12 ` [pmg-devel] applied: " Thomas Lamprecht
2023-03-24 13:30 ` [pmg-devel] [PATCH pmg-docs 1/2] config: add reference to postfix postconf Dominik Csapak
2023-03-24 13:30 ` [pmg-devel] [PATCH pmg-docs 2/2] administration: add section for statistics Dominik Csapak
2023-03-27 11:32 ` Stoiko Ivanov
2023-03-27 11:59 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2203c1a7-20e7-eea2-6400-a8e3675ca5bb@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox