Re: [pmg-devel] [PATCH pmg-docs 2/2] administration: add section for statistics

[Dominik Csapak <d.csapak@proxmox.com>]

On 3/27/23 13:32, Stoiko Ivanov wrote:
> Thanks for addressing this - This should make the experience for our users
> much better, and reduce quite a few support-requests!
> 
> In general it looks good to me and could be merged as is
> 
> One high-level suggestion and a few nits inline (could be a follow-up as
> well):
> 
> Since Statistics is its own entry in the GUI's navigation tree - why not
> have it as a dedicated chapter of the docs? (quickly tried it here - just
> putting it in a file of its own, and raising the heading levels by one
> (`-` -> `=`, `~` -> `-`) and including it in pmg-adminstration-guide.adoc
> seems to work fine)
> 
> It's not a strict necessity, and the docs to GUI matching is not 100%
> currently either (Backup/Restore is its own chapter, but under
> Configuration on the GUI for example)
> 
> Let me know what you think (and if you'll find the time soon to address it
> or if I should send the suggestions as follow-up)
> 


thanks for the review, the inline changes all make sense and i'll send a v2 shortly

as for the own chapter, it don't really have a preference here. i put
it into administration as i did not have the impression that
the amount of information would warrant it's own chapter.

from a user perspective though, it would probably better as it's own
chapter, since it's also separate in the gui as you mentioned

so i'll do that in the v2