public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api 3/4] config: postfix: make smtp-filter-timeout configurable
Date: Fri, 12 Jan 2024 10:15:29 +0100	[thread overview]
Message-ID: <220317db-d6dc-4acd-b1aa-505b4c821dea@proxmox.com> (raw)
In-Reply-To: <20230911142317.19746-4-s.ivanov@proxmox.com>

Am 11/09/2023 um 16:23 schrieb Stoiko Ivanov:
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> This patch needs the changes for pmg-docs (actually an updated
> pmg-doc-generator package installed) applied.
> 
>  src/PMG/Config.pm        | 6 ++++++
>  src/templates/main.cf.in | 3 ++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm
> index 7339e0d..eb6c5c2 100644
> --- a/src/PMG/Config.pm
> +++ b/src/PMG/Config.pm
> @@ -699,6 +699,11 @@ sub properties {
>  	    type => 'boolean',
>  	    default => 1
>  	},
> +	filter_timeout => {

Style nit: snake_case, but without checking there's probably a lot of
those casing already present? if not, or already a mix, I'd also prefer
using kebab-case here for new stuff.

> +	    description => "Timeout for the processing of one mail (in seconds)  (postfix option `smtpd_proxy_timeout` and `lmtp_data_done_timeout`)",

Can you wrap that please over multiple lines so that our << 100 cc style
rule is held up, e.g.:

            description => "Timeout for the processing of one mail (in seconds)  (postfix option"
                ." `smtpd_proxy_timeout` and `lmtp_data_done_timeout`)",

> +	    type => 'integer',
> +	    default => 600

min/max would be great to have here, makes no sense to have -10 or? and
limiting the upper site to is often helpful too, having a timeout more
than a day (86400) or week (604800) is probably a high enough limit to
catch some odd mistaken entries.

> +	},
>      };
>  }
>  





  reply	other threads:[~2024-01-12  9:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-11 14:23 [pmg-devel] [PATCH pmg-api/docs] make filter timeout configurable Stoiko Ivanov
2023-09-11 14:23 ` [pmg-devel] [PATCH pmg-api 1/4] templates: postfix: set same timeouts for before and after-queue Stoiko Ivanov
2023-09-11 14:23 ` [pmg-devel] [PATCH pmg-api 2/4] pmg-smtp-filter: refactor use of gettimeofday Stoiko Ivanov
2023-09-11 14:23 ` [pmg-devel] [PATCH pmg-api 3/4] config: postfix: make smtp-filter-timeout configurable Stoiko Ivanov
2024-01-12  9:15   ` Thomas Lamprecht [this message]
2023-09-11 14:23 ` [pmg-devel] [PATCH pmg-api 4/4] pmg-smtp-filter: die if processing took longer than the timeout Stoiko Ivanov
2024-01-12  9:19   ` Thomas Lamprecht
2023-09-11 14:23 ` [pmg-devel] [PATCH pmg-docs 1/1] doc-generator: add new option filter_timeout Stoiko Ivanov
2024-01-12  8:35 ` [pmg-devel] [PATCH pmg-api/docs] make filter timeout configurable Dominik Csapak
2024-01-12 19:59   ` Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=220317db-d6dc-4acd-b1aa-505b4c821dea@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal