Re: [pmg-devel] [PATCH pmg-api 3/4] config: postfix: make smtp-filter-timeout configurable

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 11/09/2023 um 16:23 schrieb Stoiko Ivanov:
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> This patch needs the changes for pmg-docs (actually an updated
> pmg-doc-generator package installed) applied.
> 
>  src/PMG/Config.pm        | 6 ++++++
>  src/templates/main.cf.in | 3 ++-
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm
> index 7339e0d..eb6c5c2 100644
> --- a/src/PMG/Config.pm
> +++ b/src/PMG/Config.pm
> @@ -699,6 +699,11 @@ sub properties {
>  	    type => 'boolean',
>  	    default => 1
>  	},
> +	filter_timeout => {

Style nit: snake_case, but without checking there's probably a lot of
those casing already present? if not, or already a mix, I'd also prefer
using kebab-case here for new stuff.

> +	    description => "Timeout for the processing of one mail (in seconds)  (postfix option `smtpd_proxy_timeout` and `lmtp_data_done_timeout`)",

Can you wrap that please over multiple lines so that our << 100 cc style
rule is held up, e.g.:

            description => "Timeout for the processing of one mail (in seconds)  (postfix option"
                ." `smtpd_proxy_timeout` and `lmtp_data_done_timeout`)",

> +	    type => 'integer',
> +	    default => 600

min/max would be great to have here, makes no sense to have -10 or? and
limiting the upper site to is often helpful too, having a timeout more
than a day (86400) or week (604800) is probably a high enough limit to
catch some odd mistaken entries.

> +	},
>      };
>  }
>