public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Leo Nunner <l.nunner@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-gui] gui: properly encode rule names in overview
Date: Wed, 17 May 2023 12:04:23 +0200	[thread overview]
Message-ID: <21441116-2f70-d587-fae3-3ae1a983f05f@proxmox.com> (raw)
In-Reply-To: <20230328120821.107090-1-l.nunner@proxmox.com>

Am 28/03/2023 um 14:08 schrieb Leo Nunner:
> Rule names were not HTML-encoded in the rule overview. While some
> encoding did happen, it was only on the first load for the info panel on
> the right hand side, which was overriden as soon as the edit window was
> opened/closed again.
> 
> The variable binding now gets HTML-encoded automatically, and the renderer
> for rule names has been set to Ext.htmlEncode.
> 
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
>  js/RuleConfiguration.js | 1 +
>  js/RuleInfo.js          | 3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, reworded the subject a bit though (this is a ui-only repo, so the "ui:"
tag is superfluous), thanks!




      reply	other threads:[~2023-05-17 10:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 12:08 [pmg-devel] " Leo Nunner
2023-05-17 10:04 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21441116-2f70-d587-fae3-3ae1a983f05f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.nunner@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal