From: Fiona Ebner <f.ebner@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [PATCH pmg-api 2/2] backup: warn about errors from tar
Date: Fri, 9 Oct 2026 14:56:53 +0200 [thread overview]
Message-ID: <20261009125741.867045-3-f.ebner@proxmox.com> (raw)
In-Reply-To: <20261009125741.867045-1-f.ebner@proxmox.com>
Filter out the messages about removal of leading slashes
> /bin/tar: Removing leading `/' from member names
> /bin/tar: Removing leading `/' from hard link targets
as they would appear for every backup.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
src/PMG/Backup.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/PMG/Backup.pm b/src/PMG/Backup.pm
index 79ca429..18ceda8 100644
--- a/src/PMG/Backup.pm
+++ b/src/PMG/Backup.pm
@@ -224,7 +224,12 @@ sub pmg_backup {
push($tar_cmd->@*, $sa_configs->@*);
- eval { PVE::Cmd::run($tar_cmd, quiet => 1) };
+ my $errfunc = sub {
+ my ($msg) = @_;
+ return if $msg =~ m!Removing leading `/' from (member names|hard link targets)!;
+ warn "$msg\n";
+ };
+ eval { PVE::Cmd::run($tar_cmd, quiet => 1, errfunc => $errfunc) };
die "unable to create system configuration backup: $@" if $@;
my $extradb = $include_statistics ? $statfn : '';
--
2.47.3
prev parent reply other threads:[~2026-10-09 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 12:56 [PATCH-SERIES pmg-api 0/2] backup: improve error reporting Fiona Ebner
2026-10-09 12:56 ` [PATCH pmg-api 1/2] backup: propagate error message from failed Cmd::run() invocation Fiona Ebner
2026-10-09 12:56 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009125741.867045-3-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox