From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [PATCH pmg-yew-quarantine-gui] mail view: show mark seen/unseen depending on mail state
Date: Fri, 19 Jun 2026 11:16:58 +0200 [thread overview]
Message-ID: <20260619111658.21f60b72@rosa.proxmox.com> (raw)
In-Reply-To: <20260609100235.1650066-1-d.csapak@proxmox.com>
Thanks for the patch!
gave it a spin, works as advertised!
looked through the code - and, apart from a small typo - it LGTM.
comment inline:
On Tue, 9 Jun 2026 12:02:22 +0200
Dominik Csapak <d.csapak@proxmox.com> wrote:
>..snip..
> +
> +// deserialization helper for boolean values that can be 1/0/yes/on/off/etc.
> +pub(crate) fn deserialize_flexible_bool<'de, D>(deserializer: D) -> Result<bool, D::Error>
> +where
> + D: serde::Deserializer<'de>,
> +{
> + Ok(match Value::deserialize(deserializer)? {
> + Value::Bool(b) => b,
> + Value::Number(n) => n.as_i64().is_some_and(|v| v != 0),
> + Value::String(s) => {
> + matches!(s.to_ascii_uppercase().as_str(), "1" | "on" | "yes" | "true")
this should be `to_ascii_lowercase()`
> + }
> + _ => false,
> + })
> +}
> diff --git a/src/page_mail_view.rs b/src/page_mail_view.rs
>..snip..
next prev parent reply other threads:[~2026-06-19 9:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 10:02 [PATCH pmg-yew-quarantine-gui] mail view: show mark seen/unseen depending on mail state Dominik Csapak
2026-06-19 9:16 ` Stoiko Ivanov [this message]
2026-06-19 9:32 ` superseded: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619111658.21f60b72@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox