public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [PATCH installer 2/2] pmg: ensure clamav-daemon is enabled
Date: Tue,  9 Jun 2026 12:07:56 +0200	[thread overview]
Message-ID: <20260609100805.1631021-3-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20260609100805.1631021-1-s.ivanov@proxmox.com>

the version currently in debian testing (and backported by us)
installs the service without enabling it, the tag named
`debian-1.4.4` otoh enables it.
with the back and forth unconditionally enabling it in our installer
seems like a robust measure.

follows commit:
72480b2 ("pmg: ensure clamav-freshclam is enabled")

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 Proxmox/Install.pm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 8fd51a9..1740d13 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -1438,13 +1438,18 @@ _EOD
                 "$targetdir/etc/systemd/system/multi-user.target.wants/clamav-clamonacc.service"
                 or $!{ENOENT}
                 or warn "failed to disable clamav-clamonacc.service - $!\n";
-            # clamav-freshclam is not enabled automatically anymore in recent versions - so ensure
-            # it will start - see https://salsa.debian.org/clamav-team/clamav/-/merge_requests/7
+            # clamav daemons are not enabled automatically anymore in recent versions and the
+            # upstream maintainers do change that part comparatively often - so just ensure
+            # that the services are enabled here
             syscmd(
                 "ln -sf /lib/systemd/system/clamav-freshclam.service $targetdir/etc/systemd/system/multi-user.target.wants/clamav-freshclam.service"
                 ) == 0
                 || warn "failed to enable clamav-freshclam.service - $!\n";
 
+            syscmd(
+                "ln -sf /lib/systemd/system/clamav-freshclam.service $targetdir/etc/systemd/system/multi-user.target.wants/clamav-freshclam.service"
+                ) == 0
+                || warn "failed to enable clamav-freshclam.service - $!\n";
         }
 
         if ($iso_env->{product} eq 'pve') {
-- 
2.47.3





  parent reply	other threads:[~2026-06-09 10:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09 10:07 [PATCH pve-installer/pmg-api 0/2] ensure clamav-daemon is enabled Stoiko Ivanov
2026-06-09 10:07 ` [PATCH pmg-api 1/2] d/postinst: ensure that " Stoiko Ivanov
2026-06-09 10:07 ` Stoiko Ivanov [this message]
2026-06-09 10:18   ` [PATCH installer 2/2] pmg: ensure " Christoph Heiss
2026-06-09 10:49 ` [PATCH pve-installer/pmg-api 0/2] " Thomas Lamprecht
2026-06-09 10:53   ` Thomas Lamprecht
2026-06-09 11:09   ` Stoiko Ivanov
2026-06-09 11:15     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260609100805.1631021-3-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal