public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [PATCH pmg-gui 11/15] utils: copy pbs helpers from pve-manager
Date: Wed,  3 Jun 2026 20:03:13 +0200	[thread overview]
Message-ID: <20260603180445.98770-12-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20260603180445.98770-1-s.ivanov@proxmox.com>

as we'll reuse the widgets from pve-manager for adding pbs encryption
support to PMG, copy the helpers from pve-manager.

taken from pve-manager commits:
fdde857a ("fix #4393: ui: storage backup view: make pbs-specific columns sortable")
957a53bd ("ui: add comment/verification columns to backup/content grid")
3003a59d ("ui: guest backup view: add encrypted column for PBS storages")
14ba33fb ("ui: storage: pbs: improve encryption key handling")

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 js/Utils.js | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/js/Utils.js b/js/Utils.js
index 3332f9b..0c3032f 100644
--- a/js/Utils.js
+++ b/js/Utils.js
@@ -910,6 +910,50 @@ Ext.define('PMG.Utils', {
             saupdate: ['', gettext('SpamAssassin update')],
         });
     },
+
+    render_pbs_fingerprint: (fp) => fp.substring(0, 23),
+
+    render_backup_encryption: function (v, meta, record) {
+        if (!v) {
+            return gettext('No');
+        }
+        let tip = '';
+        if (v.match(/^[a-fA-F0-9]{2}:/)) {
+            // fingerprint
+            tip = `Key fingerprint ${PMG.Utils.render_pbs_fingerprint(v)}`;
+        }
+        let icon = `<i class="fa fa-fw fa-lock good"></i>`;
+        return `<span data-qtip="${tip}">${icon} ${gettext('Encrypted')}</span>`;
+    },
+
+    render_backup_verification: function (v, meta, record) {
+        let i = (cls, txt) => `<i class="fa fa-fw fa-${cls}"></i> ${txt}`;
+        if (v === undefined || v === null) {
+            return i('question-circle-o warning', gettext('None'));
+        }
+        let tip = '';
+        let txt = gettext('Failed');
+        let iconCls = 'times critical';
+        if (v.state === 'ok') {
+            txt = gettext('OK');
+            iconCls = 'check good';
+            let now = Date.now() / 1000;
+            let task = Proxmox.Utils.parse_task_upid(v.upid);
+            let verify_time = Proxmox.Utils.render_timestamp(task.starttime);
+            tip = `Last verify task started on ${verify_time}`;
+            if (now - v.starttime > 30 * 24 * 60 * 60) {
+                tip = `Last verify task over 30 days ago: ${verify_time}`;
+                iconCls = 'check warning';
+            }
+        }
+        return `<span data-qtip="${tip}"> ${i(iconCls, txt)} </span>`;
+    },
+    verificationStateOrder: {
+        failed: 0,
+        none: 1,
+        ok: 2,
+        __default__: 3,
+    },
 });
 
 Ext.define('PMG.Async', {
-- 
2.47.3





  parent reply	other threads:[~2026-06-03 18:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 18:03 [PATCH pve-common/pmg-api/pmg-docs/pmg-gui 00/15] fix #3226: add support for encrypted backups Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pve-common 01/15] pbs-client: autogen key: rename old one if existing Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pve-common 02/15] pbs-client: add support for master public key Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-api 03/15] api: pbs remote: fix delete_password invocation Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-api 04/15] fix #3226: pbs backup: remote: add encryption key support Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-api 05/15] pbs: job: add encrypted state to snapshot listing Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-api 06/15] pbs: job: add verification " Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-api 07/15] pmgbackup: add encypted and verification state to output Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-api 08/15] api: pbs remote create/update: return parts of the configuration Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-api 09/15] api: pmgbackup: add master-pubkey properties Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-gui 10/15] pbs: snapshotview: add missing gettext invocations Stoiko Ivanov
2026-06-03 18:03 ` Stoiko Ivanov [this message]
2026-06-03 18:03 ` [PATCH pmg-gui 12/15] fix #3326: ui: pbs remote: add encryption tab to edit window Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-gui 13/15] ui: pbs remote: allow to downloading/print new encryption key Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-gui 14/15] ui: pbs snapshotview: add encryption and verification state Stoiko Ivanov
2026-06-03 18:03 ` [PATCH pmg-docs 15/15] pmgbackup: minimally document support for encrypted backups Stoiko Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603180445.98770-12-s.ivanov@proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal