From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [PATCH pmg-api] fix #7407: cluster: report: increase maximal filesize to 2M
Date: Fri, 13 Mar 2026 21:13:20 +0100 [thread overview]
Message-ID: <20260313201321.18589-1-s.ivanov@proxmox.com> (raw)
the postfix configuration files are read via PVE::INotify in our
stack and have not implicit limit.
PMG::Cluster and PMG::Report do read the same file's contents using
`file_get_contents` with a limit (explicitly set, or implicit) of 1M.
This causes the cluster-sync to fail in one reported deployment
hosting ~40k domains, with explicit transport entries and comments
(resulting in a 1.4M /etc/pmg/transport).
As it's the first occurrence of this causing an issue doubling the
limit to 2M, instead of increasing it further seems appropriate.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/PMG/Cluster.pm | 4 ++--
src/PMG/Report.pm | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PMG/Cluster.pm b/src/PMG/Cluster.pm
index 02d727ee..380cfa6e 100644
--- a/src/PMG/Cluster.pm
+++ b/src/PMG/Cluster.pm
@@ -266,10 +266,10 @@ my $cond_commit_synced_file = sub {
return;
}
- my $new = PVE::Tools::file_get_contents($srcfn, 1024 * 1024);
+ my $new = PVE::Tools::file_get_contents($srcfn, 2048 * 1024);
if (-f $dstfn) {
- my $old = PVE::Tools::file_get_contents($dstfn, 1024 * 1024);
+ my $old = PVE::Tools::file_get_contents($dstfn, 2048 * 1024);
return 0 if $new eq $old;
}
diff --git a/src/PMG/Report.pm b/src/PMG/Report.pm
index 84d1b887..20e4055d 100644
--- a/src/PMG/Report.pm
+++ b/src/PMG/Report.pm
@@ -72,7 +72,7 @@ sub dir2text {
sub {
my ($file) = @_;
$report .= "\n# cat $target_dir$file\n";
- $report .= PVE::Tools::file_get_contents($target_dir . $file) . "\n";
+ $report .= PVE::Tools::file_get_contents($target_dir . $file, 2048 * 1024) . "\n";
},
);
}
--
2.47.3
reply other threads:[~2026-03-13 20:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313201321.18589-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox