public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Hannes Laimer <h.laimer@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied-series: [PATCH pmg-api/pmg-gui v3 0/2] fix #3450: batch deletion/delivery for postfix queue
Date: Mon, 29 Sep 2025 09:36:01 +0200	[thread overview]
Message-ID: <20250929093601.4adcb54d@rosa.proxmox.com> (raw)
In-Reply-To: <20250924071314.41917-1-h.laimer@proxmox.com>

Thanks for the iteration and the testing!

applied-both patches with Maximiliano's T-b.
For pmg-api I added a follow-up to register the postfix-queue-id as a
format, and use the '-list' derivative format for your api-calls.
(this allows for elements to also be split by ',' and '\0' IIRC, and adds
a bit more of context and semantics.

for the gui - I tried to refactor a few common places in:
https://lore.proxmox.com/pmg-devel/20250929073421.16955-1-s.ivanov@proxmox.com/T/#u



On Wed, 24 Sep 2025 09:13:12 +0200
Hannes Laimer <h.laimer@proxmox.com> wrote:

> Adds a new POST endpoint that accepts both a type(delete/deliver) and a
> list of id's. This is also how batch operations are done for quarantine.
> 
> https://bugzilla.proxmox.com/show_bug.cgi?id=3450
> 
> v3, thanks @Thomas:
>  - code cleanup
>  - add more context to commit messages
>  - remove not needed checks when passing a list of ids to `postsuper -d -`
>  - ui: use INFO instead of WARNING confirm popup, same as we do for quarantine
>  - ui: no confirmation for flush of single mails, so existing behaviour of the
>    button does not change
> 
> v2:
>  - instead of 'filter' use the IDs directly
>  - UI now doesn't have extra buttons, the existing Remove and Flush ones
>    will just work with either one or multiple selected items
> 
> pmg-api:
> 
> Hannes Laimer (1):
>   fix #3450: api: queue: add POST endpoint for batch deletion/delivery
> 
>  src/PMG/API2/Postfix.pm | 40 ++++++++++++++++++++++++++++++++++++++++
>  src/PMG/Postfix.pm      | 24 ++++++++++++++++++++++++
>  2 files changed, 64 insertions(+)
> 
> 
> pmg-gui:
> 
> Hannes Laimer (1):
>   fix #3450: ui: queue: multi-select for item deletion/delivery
> 
>  js/PostfixMailQueue.js | 100 ++++++++++++++++++++++++++++-------------
>  1 file changed, 68 insertions(+), 32 deletions(-)
> 
> 
> Summary over all repositories:
>   3 files changed, 132 insertions(+), 32 deletions(-)
> 



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


      parent reply	other threads:[~2025-09-29  7:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24  7:13 [pmg-devel] " Hannes Laimer
2025-09-24  7:13 ` [pmg-devel] [PATCH pmg-api v3 1/1] fix #3450: api: queue: add POST endpoint for batch deletion/delivery Hannes Laimer
2025-09-24  7:13 ` [pmg-devel] [PATCH pmg-gui v3 1/1] fix #3450: ui: queue: multi-select for item deletion/delivery Hannes Laimer
2025-09-26  9:16 ` [pmg-devel] [PATCH pmg-api/pmg-gui v3 0/2] fix #3450: batch deletion/delivery for postfix queue Maximiliano Sandoval
2025-09-29  7:36 ` Stoiko Ivanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250929093601.4adcb54d@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal