From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui] main view: remove wrong border on flex element in top bar
Date: Wed, 24 Sep 2025 10:43:53 +0200 [thread overview]
Message-ID: <20250924084358.1224454-1-d.csapak@proxmox.com> (raw)
In the top bar, we separate the left from the right items by having an
item with 'flex: 1' in between. Due to the default xtype/markup, this
element get's a border that looks like a line (because there's no
content). In light mode it's not visible because the border has the same
color as the panel, but in dark-mode, it's visible.
To remove this border, we added a css rule to make the border/background
transparent for this item by selecting the adjacent element of the
versioninfo one.
Since we added a BETA label here too, this does not match anymore and
the line is visible.
Instead of trying to fix it in CSS once more, override the xtype of the
element to be a plain 'box' without a complicated markup (since it's
only a spacer element anyway). This removes any border/background color
too and should be more robust than adapting the css rule.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
js/MainView.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/js/MainView.js b/js/MainView.js
index 2f8dc57..d5ff643 100644
--- a/js/MainView.js
+++ b/js/MainView.js
@@ -187,6 +187,7 @@ Ext.define('PMG.MainView', {
html: '<a href="https://bugzilla.proxmox.com" target="_blank">BETA</a>',
},
{
+ xtype: 'box', // keep markup simple, has no borders/background
flex: 1,
},
{
--
2.47.3
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next reply other threads:[~2025-09-24 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 8:43 Dominik Csapak [this message]
2025-09-24 9:52 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250924084358.1224454-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox