public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api v5 07/11] spamasassin: store files in dir managed by pmg
Date: Thu, 14 Aug 2025 02:13:43 +0200	[thread overview]
Message-ID: <20250814021343.4c971228@rosa.proxmox.com> (raw)
In-Reply-To: <20250404131438.328396-7-m.sandoval@proxmox.com>

we probably should migrate the files upon upgrading (all new installations
don't have thos settings enabled by default, but everything installed
<=7.3 should have it enabled by default - so it probably will change the
behavior for users) 

On Fri,  4 Apr 2025 15:14:34 +0200
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:

> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/PMG/Config.pm       | 8 ++++----
>  src/PMG/Report.pm       | 2 +-
>  src/bin/pmg-smtp-filter | 2 +-
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/src/PMG/Config.pm b/src/PMG/Config.pm
> index 754cc791..89873f56 100644
> --- a/src/PMG/Config.pm
> +++ b/src/PMG/Config.pm
> @@ -1601,13 +1601,13 @@ sub rewrite_config_spam {
>  
>      # delete AW and bayes databases if those features are disabled
>      if (!$use_awl) {
> -	$changes = 1 if unlink '/root/.spamassassin/auto-whitelist';
> +	$changes = 1 if unlink '/var/lib/pmg/spamassassin/auto-whitelist';
>      }
>  
>      if (!$use_bayes) {
> -	$changes = 1 if unlink '/root/.spamassassin/bayes_journal';
> -	$changes = 1 if unlink '/root/.spamassassin/bayes_seen';
> -	$changes = 1 if unlink '/root/.spamassassin/bayes_toks';
> +	$changes = 1 if unlink '/var/lib/pmg/spamassassin/bayes_journal';
> +	$changes = 1 if unlink '/var/lib/pmg/spamassassin/bayes_seen';
> +	$changes = 1 if unlink '/var/lib/pmg/spamassassin/bayes_toks';
>      }
>  
>      # make sure we have the custom SA files (else cluster sync fails)
> diff --git a/src/PMG/Report.pm b/src/PMG/Report.pm
> index 79060a08..a93f00f2 100644
> --- a/src/PMG/Report.pm
> +++ b/src/PMG/Report.pm
> @@ -125,7 +125,7 @@ sub check_dns_resolution {
>  	debug => 0,
>  	local_tests_only => 0,
>  	home_dir_for_helpers => '/root',
> -	userstate_dir => '/root/.spamassassin',
> +	userstate_dir => '/var/lib/pmg/spamassassin',
>  	dont_copy_prefs   => 1,
>  	stop_at_threshold => 0,
>      });
> diff --git a/src/bin/pmg-smtp-filter b/src/bin/pmg-smtp-filter
> index e95e6458..f46d4ccf 100755
> --- a/src/bin/pmg-smtp-filter
> +++ b/src/bin/pmg-smtp-filter
> @@ -460,7 +460,7 @@ sub pre_loop_hook {
>  	debug => 0,
>  	local_tests_only => $opt_testmode || !$rbl_checks,
>  	home_dir_for_helpers => '/root',
> -	userstate_dir => '/root/.spamassassin',
> +	userstate_dir => '/var/lib/pmg/spamassassin',
>  	dont_copy_prefs   => 1,
>  	stop_at_threshold => 0,
>      });



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


  reply	other threads:[~2025-08-14  0:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 13:14 [pmg-devel] [PATCH pmg-api v5 01/11] pmgpolicy: move pid file into /run/pmgpolicy Maximiliano Sandoval
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 02/11] pmg-smtp-filter: move pid file into /run/pmg-smtp-filter Maximiliano Sandoval
2025-08-14  0:10   ` Stoiko Ivanov
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 03/11] config: store config lock in smtp-filter runtime dir Maximiliano Sandoval
2025-08-14  0:10   ` Stoiko Ivanov
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 04/11] create new users for the rule db Maximiliano Sandoval
2025-08-14  0:12   ` Stoiko Ivanov
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 05/11] postinstall: add new group for shared functionality Maximiliano Sandoval
2025-08-14  0:13   ` Stoiko Ivanov
2025-08-25 14:13     ` Maximiliano Sandoval
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 06/11] postinstall: make rrdcached be readable by the pmg group Maximiliano Sandoval
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 07/11] spamasassin: store files in dir managed by pmg Maximiliano Sandoval
2025-08-14  0:13   ` Stoiko Ivanov [this message]
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 08/11] mailqueue: make mail queue writable by pmg group Maximiliano Sandoval
2025-08-14  0:13   ` Stoiko Ivanov
2025-08-25 13:21     ` Maximiliano Sandoval
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 09/11] d/sysusers: add users for pmgpolicy and smtp-filter Maximiliano Sandoval
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 10/11] pmgpolicy: set SumplementaryGroups=systemd-journal Maximiliano Sandoval
2025-04-04 13:14 ` [pmg-devel] [PATCH pmg-api v5 11/11] fix #4926: run pmg-smtp-filter and pmgpolicy without root rights Maximiliano Sandoval
2025-08-14  0:09 ` [pmg-devel] [PATCH pmg-api v5 01/11] pmgpolicy: move pid file into /run/pmgpolicy Stoiko Ivanov
2025-08-25 12:01   ` Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250814021343.4c971228@rosa.proxmox.com \
    --to=s.ivanov@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal