* [pmg-devel] [PATCH proxmox-perl-rs] pmg-rs: remove PMG::RS::APT:Repositories module
@ 2025-05-15 8:32 Hannes Duerr
2025-05-16 12:57 ` [pmg-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Duerr @ 2025-05-15 8:32 UTC (permalink / raw)
To: pmg-devel
We can remove the PMG::RS::APT::Repositories module because we needed
its functionality in Proxmox Mail Gateway (PMG) and other products, so
we moved it to Proxmox::RS::APT::Repositories some time ago. We now only
use the new module in our code.
When users update to PMG 9, we can be sure that there is no
package using PMG::RS::APT::Repositories, so we can safely remove the
code.
Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
---
This patch should only be applied with PMG version 9
pmg-rs/Makefile | 1 -
pmg-rs/src/apt/mod.rs | 1 -
pmg-rs/src/apt/repositories.rs | 41 ----------------------------------
pmg-rs/src/lib.rs | 1 -
4 files changed, 44 deletions(-)
delete mode 100644 pmg-rs/src/apt/mod.rs
delete mode 100644 pmg-rs/src/apt/repositories.rs
diff --git a/pmg-rs/Makefile b/pmg-rs/Makefile
index 15ef08e..c944465 100644
--- a/pmg-rs/Makefile
+++ b/pmg-rs/Makefile
@@ -26,7 +26,6 @@ PERLMOD_GENPACKAGE := /usr/lib/perlmod/genpackage.pl \
--include-file=Fixup.pm
PERLMOD_PACKAGES := \
- PMG::RS::APT::Repositories \
PMG::RS::Acme \
PMG::RS::CSR \
PMG::RS::TFA
diff --git a/pmg-rs/src/apt/mod.rs b/pmg-rs/src/apt/mod.rs
deleted file mode 100644
index 574c1a7..0000000
--- a/pmg-rs/src/apt/mod.rs
+++ /dev/null
@@ -1 +0,0 @@
-mod repositories;
diff --git a/pmg-rs/src/apt/repositories.rs b/pmg-rs/src/apt/repositories.rs
deleted file mode 100644
index d8e89c2..0000000
--- a/pmg-rs/src/apt/repositories.rs
+++ /dev/null
@@ -1,41 +0,0 @@
-#[perlmod::package(name = "PMG::RS::APT::Repositories")]
-mod export {
- use anyhow::Error;
- use proxmox_apt_api_types::{
- APTChangeRepositoryOptions, APTRepositoriesResult, APTRepositoryHandle,
- };
- use proxmox_config_digest::ConfigDigest;
-
- use crate::common::apt::repositories::export as common;
-
- /// Get information about configured and standard repositories.
- #[export]
- pub fn repositories() -> Result<APTRepositoriesResult, Error> {
- common::repositories("pmg")
- }
-
- /// Add the repository identified by the `handle`.
- /// If the repository is already configured, it will be set to enabled.
- ///
- /// The `digest` parameter asserts that the configuration has not been modified.
- #[export]
- pub fn add_repository(
- handle: APTRepositoryHandle,
- digest: Option<ConfigDigest>,
- ) -> Result<(), Error> {
- common::add_repository(handle, "pmg", digest)
- }
-
- /// Change the properties of the specified repository.
- ///
- /// The `digest` parameter asserts that the configuration has not been modified.
- #[export]
- pub fn change_repository(
- path: &str,
- index: usize,
- options: APTChangeRepositoryOptions,
- digest: Option<ConfigDigest>,
- ) -> Result<(), Error> {
- common::change_repository(path, index, options, digest)
- }
-}
diff --git a/pmg-rs/src/lib.rs b/pmg-rs/src/lib.rs
index 0ebe285..5f1f27c 100644
--- a/pmg-rs/src/lib.rs
+++ b/pmg-rs/src/lib.rs
@@ -6,7 +6,6 @@ use proxmox_apt_api_types::APTUpdateInfo;
pub mod common;
pub mod acme;
-pub mod apt;
pub mod csr;
pub mod tfa;
--
2.39.5
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pmg-devel] applied: [PATCH proxmox-perl-rs] pmg-rs: remove PMG::RS::APT:Repositories module
2025-05-15 8:32 [pmg-devel] [PATCH proxmox-perl-rs] pmg-rs: remove PMG::RS::APT:Repositories module Hannes Duerr
@ 2025-05-16 12:57 ` Wolfgang Bumiller
0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Bumiller @ 2025-05-16 12:57 UTC (permalink / raw)
To: Hannes Duerr; +Cc: pmg-devel
applied, thanks
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-16 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-15 8:32 [pmg-devel] [PATCH proxmox-perl-rs] pmg-rs: remove PMG::RS::APT:Repositories module Hannes Duerr
2025-05-16 12:57 ` [pmg-devel] applied: " Wolfgang Bumiller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal