[pmg-devel] [PATCH pmg-gui 1/4] login view: change formula name as per our style guide

[pmg-devel] [PATCH pmg-gui 1/4] login view: change formula name as per our style guide

[Dominik Csapak]

use camelCase instead of snake_case

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
sent upfront because it's not a fix but noticed while fixing the rest

 js/LoginView.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/js/LoginView.js b/js/LoginView.js
index c375d75..5fbaa4a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -7,7 +7,7 @@ Ext.define('PMG.LoginView', {
 	    oidc: false,
 	},
 	formulas: {
-	    button_text: function(get) {
+	    buttonText: function(get) {
 		if (get("oidc") === true) {
 		    return gettext("Login (OpenID Connect redirect)");
 		} else {
@@ -396,7 +396,7 @@ Ext.define('PMG.LoginView', {
 			},
 			{
 			    bind: {
-				text: "{button_text}",
+				text: "{buttonText}",
 			    },
 			    reference: 'loginButton',
 			},
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

[pmg-devel] [PATCH pmg-gui 2/4] login view: fix realm change handler

[Dominik Csapak]

record here can also be 'null', so it's not enough to check for
undefined. While at it, change the statement to conform to our style
guide.

This also fixes the quarantine link popup, because an exception in
a change handler interrupts normal extjs operation, which leads
to an invalid extjs state here.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/LoginView.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/js/LoginView.js b/js/LoginView.js
index 5fbaa4a..fe4064f 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -204,7 +204,9 @@ Ext.define('PMG.LoginView', {
 	    'field[name=realm]': {
 		change: function(f, value) {
 		    let record = f.store.getById(value);
-		    if (record === undefined) return;
+		    if (!record) {
+			return;
+		    }
 		    let data = record.data;
 		    this.getViewModel().set("oidc", data.type === "oidc");
 		},
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

[pmg-devel] [PATCH pmg-gui 3/4] login view: hide realm selector on quarantine view

[Dominik Csapak]

when we target the quarantine view, we don't want to show the realm
field, since the only valid users here are from LDAP and that is not a
realm in that sense.

We do this by moving the realmfield hide/disable up before the
autologin, but after the targetview check.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/LoginView.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/js/LoginView.js b/js/LoginView.js
index fe4064f..20dfbb9 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -34,6 +34,10 @@ Ext.define('PMG.LoginView', {
 	    // hide save username field for quarantine view
 	    me.lookup('saveunField').setVisible(false);
 
+	    // disable/hide realm field for quarantine view
+	    realmfield.setDisabled(true);
+	    realmfield.setHidden(true);
+
 	    realmfield.setValue('quarantine');
 
 	    // try autologin with quarantine ticket from URL
@@ -51,7 +55,6 @@ Ext.define('PMG.LoginView', {
 	    let loginwin = me.lookup('loginwindow');
 	    loginwin.autoShow = false;
 	    loginwin.setVisible(false);
-	    realmfield.setDisabled(true);
 
 	    me.lookup('usernameField').setValue(username);
 	    me.lookup('passwordField').setValue(ticket);
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

[pmg-devel] [PATCH pmg-gui 4/4] login view: don't show save username field in quarantineview

[Dominik Csapak]

like we had before, this is a regression from the recent oidc changes.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/LoginView.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/js/LoginView.js b/js/LoginView.js
index 20dfbb9..67940ed 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -14,6 +14,9 @@ Ext.define('PMG.LoginView', {
 		    return gettext("Login");
 		}
 	    },
+	    showSaveUser: function(get) {
+		return this.getView().targetview !== 'quarantineview' && !get('oidc');
+	    },
 	},
     },
 
@@ -392,7 +395,7 @@ Ext.define('PMG.LoginView', {
 			    labelWidth: 150,
 			    submitValue: false,
 			    bind: {
-				visible: "{!oidc}",
+				visible: "{showSaveUser}",
 			    },
 			},
 			{
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

[pmg-devel] applied-series: [PATCH pmg-gui 1/4] login view: change formula name as per our style guide

[Thomas Lamprecht]

Am 27.02.25 um 10:37 schrieb Dominik Csapak:
> use camelCase instead of snake_case
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> sent upfront because it's not a fix but noticed while fixing the rest
> 
>  js/LoginView.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied series, thanks!


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel