[pmg-devel] [PATCH pmg-gui 2/4] login view: fix realm change handler

[Dominik Csapak <d.csapak@proxmox.com>]

record here can also be 'null', so it's not enough to check for
undefined. While at it, change the statement to conform to our style
guide.

This also fixes the quarantine link popup, because an exception in
a change handler interrupts normal extjs operation, which leads
to an invalid extjs state here.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/LoginView.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/js/LoginView.js b/js/LoginView.js
index 5fbaa4a..fe4064f 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -204,7 +204,9 @@ Ext.define('PMG.LoginView', {
 	    'field[name=realm]': {
 		change: function(f, value) {
 		    let record = f.store.getById(value);
-		    if (record === undefined) return;
+		    if (!record) {
+			return;
+		    }
 		    let data = record.data;
 		    this.getViewModel().set("oidc", data.type === "oidc");
 		},
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel