From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui 1/4] login view: change formula name as per our style guide
Date: Thu, 27 Feb 2025 10:37:45 +0100 [thread overview]
Message-ID: <20250227093748.1429459-1-d.csapak@proxmox.com> (raw)
use camelCase instead of snake_case
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
sent upfront because it's not a fix but noticed while fixing the rest
js/LoginView.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/js/LoginView.js b/js/LoginView.js
index c375d75..5fbaa4a 100644
--- a/js/LoginView.js
+++ b/js/LoginView.js
@@ -7,7 +7,7 @@ Ext.define('PMG.LoginView', {
oidc: false,
},
formulas: {
- button_text: function(get) {
+ buttonText: function(get) {
if (get("oidc") === true) {
return gettext("Login (OpenID Connect redirect)");
} else {
@@ -396,7 +396,7 @@ Ext.define('PMG.LoginView', {
},
{
bind: {
- text: "{button_text}",
+ text: "{buttonText}",
},
reference: 'loginButton',
},
--
2.39.5
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next reply other threads:[~2025-02-27 9:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 9:37 Dominik Csapak [this message]
2025-02-27 9:37 ` [pmg-devel] [PATCH pmg-gui 2/4] login view: fix realm change handler Dominik Csapak
2025-02-27 9:37 ` [pmg-devel] [PATCH pmg-gui 3/4] login view: hide realm selector on quarantine view Dominik Csapak
2025-02-27 9:37 ` [pmg-devel] [PATCH pmg-gui 4/4] login view: don't show save username field in quarantineview Dominik Csapak
2025-02-27 9:42 ` [pmg-devel] applied-series: [PATCH pmg-gui 1/4] login view: change formula name as per our style guide Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227093748.1429459-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal