[pmg-devel] [PATCH pmg-api 4/4] api: users: rework userid validation

[Stoiko Ivanov <s.ivanov@proxmox.com>]

reuse the existing helpers in PMG::Utils to forbid creating:
* users with an unallowed realm
* passing a different realm than what we receive in the userid
* users in the pam realm

Reported-by: Mira Limbeck <m.limbeck@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 src/PMG/API2/Users.pm | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/PMG/API2/Users.pm b/src/PMG/API2/Users.pm
index f137b87..1edf29a 100644
--- a/src/PMG/API2/Users.pm
+++ b/src/PMG/API2/Users.pm
@@ -111,9 +111,6 @@ __PACKAGE__->register_method ({
 	    die "User '$param->{userid}' already exists\n"
 		if $cfg->{$param->{userid}};
 
-	    die "Currently you cannot create user in the PAM realm\n"
-		if $param->{realm} && $param->{realm} eq 'pam';
-
 	    my $entry = {};
 	    foreach my $k (keys %$param) {
 		my $v = $param->{$k};
@@ -124,10 +121,21 @@ __PACKAGE__->register_method ({
 		}
 	    }
 
+	    my ($userid, $username, $realm) = PMG::Utils::verify_username($entry->{userid});
+	    my $realm_regex = PMG::Utils::valid_pmg_realm_regex();
+	    die "invalid realm in userid\n" if $realm !~ /$realm_regex/;
+
+	    if ($entry->{realm}) {
+		die "realm parameter does not fit userid\n" if ($entry->{realm} ne $realm);
+	    } else {
+		$entry->{realm} = $realm;
+	    }
+
+	    die "Currently you cannot create user in the PAM realm\n" if $entry->{realm} eq 'pam';
+
 	    $entry->{enable} //= 0;
 	    $entry->{expire} //= 0;
 	    $entry->{role} //= 'audit';
-	    $entry->{realm} //= 'pmg';
 
 	    $cfg->{$param->{userid}} = $entry;
 
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel