public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-gui] dkim selector view: fix viewing larger DKIM TXT records
Date: Wed, 26 Feb 2025 17:07:43 +0100	[thread overview]
Message-ID: <20250226160743.2588-1-d.csapak@proxmox.com> (raw)

It seems the 'grow' feature of the textarea only works properly on user
input, not when automatically filling it with data. So instead of trying
to do that, which only ever clipped the record if it was too large,
simply use a fixed size that is enough for 4096 bit sized keys and show
a scrollbar for larger ones.

With having a fixed height, and horizontal resizing a textarea also not
working properly in an edit window, prevent the whole window from
resizing.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 js/DKIMSettings.js | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/js/DKIMSettings.js b/js/DKIMSettings.js
index e5f6c76..323f0b6 100644
--- a/js/DKIMSettings.js
+++ b/js/DKIMSettings.js
@@ -53,7 +53,7 @@ Ext.define('PMG.SelectorViewer', {
     title: gettext('Selector'),
 
     width: 800,
-    resizable: true,
+    resizable: false,
 
     items: [
 	{
@@ -69,9 +69,7 @@ Ext.define('PMG.SelectorViewer', {
 	{
 	    xtype: 'textarea',
 	    editable: false,
-	    grow: true,
-	    growMin: 150,
-	    growMax: 400,
+	    height: 220,
 	    fieldLabel: gettext('DNS TXT Record'),
 	    name: 'record',
 	    value: 'Could not read private key!',
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


             reply	other threads:[~2025-02-26 16:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26 16:07 Dominik Csapak [this message]
2025-02-26 16:20 ` [pmg-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250226160743.2588-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal