Re: [pmg-devel] [PATCH pmg-docs] pmgconfig: document DKIM signing local mail

[Stoiko Ivanov <s.ivanov@proxmox.com>]

Thanks for the fast feedback - good suggestions!

one question inline:

On Wed, 26 Feb 2025 15:39:25 +0100
Fiona Ebner <f.ebner@proxmox.com> wrote:

> Am 26.02.25 um 15:18 schrieb Stoiko Ivanov:
> > Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> > ---
> >  pmgconfig.adoc | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/pmgconfig.adoc b/pmgconfig.adoc
> > index 3ac8973..c093051 100644
> > --- a/pmgconfig.adoc
> > +++ b/pmgconfig.adoc
> > @@ -575,6 +575,13 @@ You can either sign all mails received on the internal port using the domain of
> >  the envelope sender address or create a list of domains, for which emails
> >  should be signed, defaulting to the list of relay domains.
> >  
> > +Mails generated by {pmg} itself, like notifications and reports, usually have
> > +an empty envelope. Thus they will only be signed if you have selected `header`
> > +as source of the signing domain and have set a RFC5322.From with a domain that  
> 
> "as source" -> "as the source"
> 
> s/a RFC/an RFC/ (because it's read as "ar-ef-zee")
> 
> "with a domain" -> "to a domain"?
the from header has a display name ("Stoiko Ivanov") and an address
(<s.ivanov@proxmox.com>) - so setting this 'to a domain that ...' seems
unfitting, and writing:
have set a RFC5322.From with an address that is in a domain...
seems a bit unwieldy?

would be grateful for alternatives

> 
> > +would be signed as `From:` setting in the  
> 
> "as `From:` setting" -> "as a `From:` setting"?
> 
> > +xref:pmgconfig_spamdetector_quarantine[spam quarantine options] for spamreports  
> 
> "spamreports" -> "spam reports"?
> 
> > +and quarantine links, and in the xref:pmgconfig_systemconfig[system options] for
> > +other mails send by {pmg}.  
> 
> s/send/sent/
> 
> >  
> >  Enable DKIM Signing::
> >    
> 



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel