From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api v2 1/3] ruledb: content-type: drop unreachable fallback for only_content
Date: Tue, 25 Feb 2025 12:15:02 +0100 [thread overview]
Message-ID: <20250225111504.439075-2-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20250225111504.439075-1-s.ivanov@proxmox.com>
the default of 'only_content' gets set when fetching the entries from the
database in load_attr - and it defaults to false.
the `// 1` is thus never needed and confusing.
Noticed while debugging another issue, and considered if this false
setting might be the cause.
Fixes:
af418f4 ("ruledb: content-type: add flag for matching only based on magic/content")
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/PMG/RuleDB/ContentTypeFilter.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PMG/RuleDB/ContentTypeFilter.pm b/src/PMG/RuleDB/ContentTypeFilter.pm
index 6818de1..ef1d377 100644
--- a/src/PMG/RuleDB/ContentTypeFilter.pm
+++ b/src/PMG/RuleDB/ContentTypeFilter.pm
@@ -120,7 +120,7 @@ sub parse_entity {
my $glob_ct = $entity->{PMX_glob_ct};
- my $check_only_content = ${self}->{only_content} // 1;
+ my $check_only_content = ${self}->{only_content};
if ($magic_ct && $magic_ct =~ m|$self->{field_value}|) {
push @$res, $id;
--
2.39.5
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-02-25 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 11:15 [pmg-devel] [PATCH pmg-api v2 0/3] fix content-type matching for parts without bodyhandle Stoiko Ivanov
2025-02-25 11:15 ` Stoiko Ivanov [this message]
2025-02-25 11:15 ` [pmg-devel] [PATCH pmg-api v2 2/3] ruledb: content-type: do not rely on PMX_header_ct Stoiko Ivanov
2025-02-25 11:15 ` [pmg-devel] [PATCH pmg-api v2 3/3] utils: drop unneeded PMX_header_ct Stoiko Ivanov
2025-02-25 13:45 ` [pmg-devel] [PATCH pmg-api v2 0/3] fix content-type matching for parts without bodyhandle Dominik Csapak
2025-02-25 16:50 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225111504.439075-2-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal