From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api v2 0/2] change sample-entries in default Who-Objects and check in pmg7to8
Date: Fri, 21 Feb 2025 09:51:49 +0100 [thread overview]
Message-ID: <20250221095149.51d10c2d@rosa.proxmox.com> (raw)
In-Reply-To: <f52bfbb8-4241-4045-821b-500f61a6ecb1@proxmox.com>
On Fri, 21 Feb 2025 09:46:00 +0100
Dominik Csapak <d.csapak@proxmox.com> wrote:
> works as intended, but i just have a question:
>
> do we usually update the pmg/pve XtoY script that long beforehand?
> because this will now trigger if people now do a 7to8 upgrade
> and call it after the upgrade step then
In this case I'd say it's ok - the issue here is the "wrong" example
addresses - so if someone migrating from 7 or even without runs this and
is notified they can take action in any case. by adding it now we make
sure it will remain in place when we base pmg8to9 on pmg7to8.
>
> (i believe this is intended for the 8to9 script ?)
>
> if that's a non-issue, consider this
>
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
>
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-02-21 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 17:16 Stoiko Ivanov
2025-02-17 17:16 ` [pmg-devel] [PATCH pmg-api v2 1/2] fix #5972: ruledb: default ruleset: use .example as TLD Stoiko Ivanov
2025-02-17 17:16 ` [pmg-devel] [PATCH pmg-api v2 2/2] pmg7to8: add check for deprecated default entries in ruledb Stoiko Ivanov
2025-02-21 8:46 ` [pmg-devel] [PATCH pmg-api v2 0/2] change sample-entries in default Who-Objects and check in pmg7to8 Dominik Csapak
2025-02-21 8:51 ` Stoiko Ivanov [this message]
2025-02-21 15:56 ` [pmg-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221095149.51d10c2d@rosa.proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal