From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api v2 2/2] pmg7to8: add check for deprecated default entries in ruledb
Date: Mon, 17 Feb 2025 18:16:15 +0100 [thread overview]
Message-ID: <20250217171615.21255-3-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20250217171615.21255-1-s.ivanov@proxmox.com>
with a new section for future checks of the rule database.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
src/PMG/CLI/pmg7to8.pm | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/src/PMG/CLI/pmg7to8.pm b/src/PMG/CLI/pmg7to8.pm
index d0a6cbe..a23a0ba 100644
--- a/src/PMG/CLI/pmg7to8.pm
+++ b/src/PMG/CLI/pmg7to8.pm
@@ -13,6 +13,7 @@ use PMG::API2::APT;
use PMG::API2::Certificates;
use PMG::API2::Cluster;
use PMG::RESTEnvironment;
+use PMG::RuleDB;
use PMG::Utils;
use Term::ANSIColor;
@@ -526,6 +527,25 @@ sub check_dkms_modules {
}
}
+sub check_ruledb {
+ log_info("Check the rulesystem...");
+
+ my $rdb = PMG::RuleDB->new();
+ my $ogroups = $rdb->load_objectgroups("who");
+ for my $who ($ogroups->@*) {
+ my $group_name = $who->{name};
+ next if ($group_name ne 'Blacklist' && $group_name ne 'Whitelist');
+ my $objects = $rdb->load_group_objects($who->{id});
+ for my $obj ($objects->@*) {
+ if ($obj->{address} =~ m/(?:no)?mail\@fromthisdomain.com/) {
+ log_warn("deprecated default entry in '$group_name' present: $obj->{address}\n"
+ ." Consider removing it");
+ }
+ }
+ }
+ return;
+}
+
sub check_misc {
print_header("MISCELLANEOUS CHECKS");
my $ssh_config = eval { PVE::Tools::file_get_contents('/root/.ssh/config') };
@@ -637,6 +657,7 @@ __PACKAGE__->register_method ({
code => sub {
my ($param) = @_;
+ check_ruledb();
check_pmg_packages();
check_cluster_status();
my $upgraded_db = check_running_postgres();
--
2.39.5
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-02-17 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 17:16 [pmg-devel] [PATCH pmg-api v2 0/2] change sample-entries in default Who-Objects and check in pmg7to8 Stoiko Ivanov
2025-02-17 17:16 ` [pmg-devel] [PATCH pmg-api v2 1/2] fix #5972: ruledb: default ruleset: use .example as TLD Stoiko Ivanov
2025-02-17 17:16 ` Stoiko Ivanov [this message]
2025-02-21 8:46 ` [pmg-devel] [PATCH pmg-api v2 0/2] change sample-entries in default Who-Objects and check in pmg7to8 Dominik Csapak
2025-02-21 8:51 ` Stoiko Ivanov
2025-02-21 15:56 ` [pmg-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217171615.21255-3-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal