[pmg-devel] [PATCH pmg-docs] pmg-mail-filter: clarify matching of Who objects

[pmg-devel] [PATCH pmg-docs] pmg-mail-filter: clarify matching of Who objects

[Friedrich Weber]

In particular, explain that Who objects match against Envelope From
and Envelope To, not the From: and To: mail headers. This is
occasionally a source of confusion in enterprise support.

Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
 pmg-mail-filter.adoc | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/pmg-mail-filter.adoc b/pmg-mail-filter.adoc
index 235f156..65d28b6 100644
--- a/pmg-mail-filter.adoc
+++ b/pmg-mail-filter.adoc
@@ -265,6 +265,16 @@ We have two important 'Who' objects called 'Blacklist' and
 'Whitelist'. These are used in the default ruleset to globally block
 or allow specific senders.
 
+Note that 'Who' objects match against the mail addresses given during the SMTP
+dialog:
+
+* 'Who' objects in the 'FROM' category match against the mail address given in
+  the `MAIL FROM` command (the Envelope From).
+* 'Who' objects in the 'TO' category match against the mail address given in
+  the `MAIL TO` command (the Envelope To).
+
+If you want to match against the `From:` or `To:` header fields of the mail,
+use a 'What' object with type 'Match Field' instead.
 
 [[pmg_mailfilter_what]]
 'What' objects
-- 
2.39.5



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

Re: [pmg-devel] [PATCH pmg-docs] pmg-mail-filter: clarify matching of Who objects

[Stoiko Ivanov]

Thanks for addressing this!


On Thu,  6 Feb 2025 16:16:20 +0100
Friedrich Weber <f.weber@proxmox.com> wrote:

> In particular, explain that Who objects match against Envelope From
> and Envelope To, not the From: and To: mail headers. This is
> occasionally a source of confusion in enterprise support.
> 
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
>  pmg-mail-filter.adoc | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/pmg-mail-filter.adoc b/pmg-mail-filter.adoc
> index 235f156..65d28b6 100644
> --- a/pmg-mail-filter.adoc
> +++ b/pmg-mail-filter.adoc
> @@ -265,6 +265,16 @@ We have two important 'Who' objects called 'Blacklist' and
>  'Whitelist'. These are used in the default ruleset to globally block
>  or allow specific senders.
>  
> +Note that 'Who' objects match against the mail addresses given during the SMTP
> +dialog:
maybe also mention that this is the information you see in the
journal/logs by default?
> +
> +* 'Who' objects in the 'FROM' category match against the mail address given in
> +  the `MAIL FROM` command (the Envelope From).
> +* 'Who' objects in the 'TO' category match against the mail address given in
> +  the `MAIL TO` command (the Envelope To).
the smtp-verb is RCPT (`RCPT TO`)



> +
> +If you want to match against the `From:` or `To:` header fields of the mail,
> +use a 'What' object with type 'Match Field' instead.
>  
>  [[pmg_mailfilter_what]]
>  'What' objects



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

Re: [pmg-devel] [PATCH pmg-docs] pmg-mail-filter: clarify matching of Who objects

[Friedrich Weber]

Thanks for the quick review!

On 06/02/2025 16:30, Stoiko Ivanov wrote:
> [...]
> On Thu,  6 Feb 2025 16:16:20 +0100
> Friedrich Weber <f.weber@proxmox.com> wrote:
> 
>> In particular, explain that Who objects match against Envelope From
>> and Envelope To, not the From: and To: mail headers. This is
>> occasionally a source of confusion in enterprise support.
>>
>> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
>> ---
>>  pmg-mail-filter.adoc | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/pmg-mail-filter.adoc b/pmg-mail-filter.adoc
>> index 235f156..65d28b6 100644
>> --- a/pmg-mail-filter.adoc
>> +++ b/pmg-mail-filter.adoc
>> @@ -265,6 +265,16 @@ We have two important 'Who' objects called 'Blacklist' and
>>  'Whitelist'. These are used in the default ruleset to globally block
>>  or allow specific senders.
>>  
>> +Note that 'Who' objects match against the mail addresses given during the SMTP
>> +dialog:
> maybe also mention that this is the information you see in the
> journal/logs by default?

Makes sense, will add!

>> +
>> +* 'Who' objects in the 'FROM' category match against the mail address given in
>> +  the `MAIL FROM` command (the Envelope From).
>> +* 'Who' objects in the 'TO' category match against the mail address given in
>> +  the `MAIL TO` command (the Envelope To).
> the smtp-verb is RCPT (`RCPT TO`)

Urgh, sorry about that, thanks for spotting it.

Will send a v2.


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel

Re: [pmg-devel] [PATCH pmg-docs] pmg-mail-filter: clarify matching of Who objects

[Friedrich Weber]

On 06/02/2025 16:54, Friedrich Weber wrote:
> Thanks for the quick review!
> 
> On 06/02/2025 16:30, Stoiko Ivanov wrote:
>> [...]
>> On Thu,  6 Feb 2025 16:16:20 +0100
>> Friedrich Weber <f.weber@proxmox.com> wrote:
>>
>>> In particular, explain that Who objects match against Envelope From
>>> and Envelope To, not the From: and To: mail headers. This is
>>> occasionally a source of confusion in enterprise support.
>>>
>>> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
>>> ---
>>>  pmg-mail-filter.adoc | 10 ++++++++++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/pmg-mail-filter.adoc b/pmg-mail-filter.adoc
>>> index 235f156..65d28b6 100644
>>> --- a/pmg-mail-filter.adoc
>>> +++ b/pmg-mail-filter.adoc
>>> @@ -265,6 +265,16 @@ We have two important 'Who' objects called 'Blacklist' and
>>>  'Whitelist'. These are used in the default ruleset to globally block
>>>  or allow specific senders.
>>>  
>>> +Note that 'Who' objects match against the mail addresses given during the SMTP
>>> +dialog:
>> maybe also mention that this is the information you see in the
>> journal/logs by default?
> 
> Makes sense, will add!
> 
>>> +
>>> +* 'Who' objects in the 'FROM' category match against the mail address given in
>>> +  the `MAIL FROM` command (the Envelope From).
>>> +* 'Who' objects in the 'TO' category match against the mail address given in
>>> +  the `MAIL TO` command (the Envelope To).
>> the smtp-verb is RCPT (`RCPT TO`)
> 
> Urgh, sorry about that, thanks for spotting it.
> 
> Will send a v2.

sent a v2:

https://lore.proxmox.com/pmg-devel/20250217115517.40171-1-f.weber@proxmox.com/


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel