* [pmg-devel] [PATCH pmg-api] api: document that SSL fingerprints are SHA-256
@ 2024-10-30 10:45 Maximiliano Sandoval
2024-10-30 11:28 ` Fabian Grünbichler
0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2024-10-30 10:45 UTC (permalink / raw)
To: pmg-devel
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
The regex pattern bellow matches the lenght (64 characters plus colons) of a
SHA-256 fingerprint.
src/PMG/API2/Cluster.pm | 2 +-
src/PMG/CLI/pmgcm.pm | 2 +-
src/PMG/ClusterConfig.pm | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/PMG/API2/Cluster.pm b/src/PMG/API2/Cluster.pm
index 84dafabb..df5df949 100644
--- a/src/PMG/API2/Cluster.pm
+++ b/src/PMG/API2/Cluster.pm
@@ -409,7 +409,7 @@ __PACKAGE__->register_method({
type => 'string', format => 'ip',
},
fingerprint => {
- description => "SSL certificate fingerprint.",
+ description => "SSL certificate SHA-256 fingerprint.",
type => 'string',
pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
},
diff --git a/src/PMG/CLI/pmgcm.pm b/src/PMG/CLI/pmgcm.pm
index ecf9cc76..a2d46910 100644
--- a/src/PMG/CLI/pmgcm.pm
+++ b/src/PMG/CLI/pmgcm.pm
@@ -167,7 +167,7 @@ __PACKAGE__->register_method({
type => 'string', format => 'ip',
},
fingerprint => {
- description => "SSL certificate fingerprint.",
+ description => "SSL certificate SHA-256 fingerprint.",
type => 'string',
pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
optional => 1,
diff --git a/src/PMG/ClusterConfig.pm b/src/PMG/ClusterConfig.pm
index c52508dc..2ca1b104 100644
--- a/src/PMG/ClusterConfig.pm
+++ b/src/PMG/ClusterConfig.pm
@@ -73,7 +73,7 @@ sub properties {
pattern => valid_ssh_pubkey_regex(),
},
fingerprint => {
- description => "SSL certificate fingerprint.",
+ description => "SSL certificate SHA-256 fingerprint.",
type => 'string',
pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
},
--
2.39.5
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pmg-devel] [PATCH pmg-api] api: document that SSL fingerprints are SHA-256
2024-10-30 10:45 [pmg-devel] [PATCH pmg-api] api: document that SSL fingerprints are SHA-256 Maximiliano Sandoval
@ 2024-10-30 11:28 ` Fabian Grünbichler
0 siblings, 0 replies; 2+ messages in thread
From: Fabian Grünbichler @ 2024-10-30 11:28 UTC (permalink / raw)
To: Maximiliano Sandoval, pmg-devel
> Maximiliano Sandoval <m.sandoval@proxmox.com> hat am 30.10.2024 11:45 CET geschrieben:
>
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> The regex pattern bellow matches the lenght (64 characters plus colons) of a
> SHA-256 fingerprint.
and there is a standard option for it in PVE::JSONSchema that should be used instead ;)
it has one slight difference, but that can be accounted here easily if needed (it allows lower case hex characters as well as upper case).
>
> src/PMG/API2/Cluster.pm | 2 +-
> src/PMG/CLI/pmgcm.pm | 2 +-
> src/PMG/ClusterConfig.pm | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/PMG/API2/Cluster.pm b/src/PMG/API2/Cluster.pm
> index 84dafabb..df5df949 100644
> --- a/src/PMG/API2/Cluster.pm
> +++ b/src/PMG/API2/Cluster.pm
> @@ -409,7 +409,7 @@ __PACKAGE__->register_method({
> type => 'string', format => 'ip',
> },
> fingerprint => {
> - description => "SSL certificate fingerprint.",
> + description => "SSL certificate SHA-256 fingerprint.",
> type => 'string',
> pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> },
> diff --git a/src/PMG/CLI/pmgcm.pm b/src/PMG/CLI/pmgcm.pm
> index ecf9cc76..a2d46910 100644
> --- a/src/PMG/CLI/pmgcm.pm
> +++ b/src/PMG/CLI/pmgcm.pm
> @@ -167,7 +167,7 @@ __PACKAGE__->register_method({
> type => 'string', format => 'ip',
> },
> fingerprint => {
> - description => "SSL certificate fingerprint.",
> + description => "SSL certificate SHA-256 fingerprint.",
> type => 'string',
> pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> optional => 1,
> diff --git a/src/PMG/ClusterConfig.pm b/src/PMG/ClusterConfig.pm
> index c52508dc..2ca1b104 100644
> --- a/src/PMG/ClusterConfig.pm
> +++ b/src/PMG/ClusterConfig.pm
> @@ -73,7 +73,7 @@ sub properties {
> pattern => valid_ssh_pubkey_regex(),
> },
> fingerprint => {
> - description => "SSL certificate fingerprint.",
> + description => "SSL certificate SHA-256 fingerprint.",
> type => 'string',
> pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> },
> --
> 2.39.5
>
>
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-30 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-30 10:45 [pmg-devel] [PATCH pmg-api] api: document that SSL fingerprints are SHA-256 Maximiliano Sandoval
2024-10-30 11:28 ` Fabian Grünbichler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox