From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pmg-devel@lists.proxmox.com
Subject: [pmg-devel] [PATCH pmg-api v2 0/2] sa-custom: move shadow config next to live config
Date: Fri, 4 Oct 2024 15:47:00 +0200 [thread overview]
Message-ID: <20241004134702.14522-1-s.ivanov@proxmox.com> (raw)
supersedes: https://lore.proxmox.com/pmg-devel/7d32a0e7-083e-4c2d-bcca-0dd55e0ec5cc@proxmox.com/T/#t
changes v1->v2:
* following Thomas' and Dominik's feedback simply moved the shadow file to
the same directory as the live one (after checking what SA does when
parsing its config) - Thanks for the suggestion!
* patch 2/2 moves the file upon package installation.
original cover-letter for v1:
the custom scores are kept in /var/cache/pmg-scores.cf, until they are
applied, by moving them to /etc/mail/spamassassin/pmg-scores.cf.
This currently happens with perl's `rename` function [0], which is a
wrapper for rename(2). `rename` does not work across filesystem
boundaries (errors out with EXDEV).
having `/var` on another filesystem is becoming less common, but
should probably be supported.
following the recommendation of [0] switch over to `File::Copy::move`,
and add some error-checking. File::Copy is shipped with
perl-modules-5.36, thus it does not introduce a new dependency
reported in our community-forum:
https://forum.proxmox.com/threads/.154814/
tested in a container with a seperate volume for `/var/cache`.
other occurences of `rename` in the repo should not be affected
(moving files within the same directory, or e.g. from /etc/pmg/master
to /etc/pmg).
[0] https://perldoc.perl.org/functions/rename
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Stoiko Ivanov (2):
sa-custom: move shadow config to the same directory
d/postinst: move pmg-scores.cf shadow file to new location
debian/postinst | 11 +++++++++++
src/PMG/SACustom.pm | 6 ++++--
2 files changed, 15 insertions(+), 2 deletions(-)
--
2.39.5
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next reply other threads:[~2024-10-04 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 13:47 Stoiko Ivanov [this message]
2024-10-04 13:47 ` [pmg-devel] [PATCH pmg-api v2 1/2] sa-custom: move shadow config to the same directory Stoiko Ivanov
2024-10-04 13:47 ` [pmg-devel] [PATCH pmg-api v2 2/2] d/postinst: move pmg-scores.cf shadow file to new location Stoiko Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241004134702.14522-1-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox