public inbox for pmg-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files
@ 2024-08-07 10:49 Maximiliano Sandoval
  2024-08-07 10:49 ` [pmg-devel] [PATCH pmg-docs 2/3] fix typos in documentation Maximiliano Sandoval
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Maximiliano Sandoval @ 2024-08-07 10:49 UTC (permalink / raw)
  To: pmg-devel

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 asciidoc-pmg.in       | 6 +++---
 asciidoc/pmg-docs.css | 4 ++--
 scan-adoc-refs        | 6 +++---
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/asciidoc-pmg.in b/asciidoc-pmg.in
index 532ea7f..fefca5e 100644
--- a/asciidoc-pmg.in
+++ b/asciidoc-pmg.in
@@ -79,7 +79,7 @@ sub pop_environment {
     die "unable to pop env '$env'" if !defined($last_stack_entry);
 
     my ($last_env, $skip) = @$last_stack_entry;
-    die "environment missmatch (${last_env} != $env)\n" if $last_env ne $env;
+    die "environment mismatch (${last_env} != $env)\n" if $last_env ne $env;
 
     if (!scalar(@$env_stack)) {
 	$env_skip = 0;
@@ -213,7 +213,7 @@ sub prepare_adoc_file {
 	chomp $line;
 	if ($line =~ m/^if(n?)def::(\S+)\[(.*)\]\s*$/) {
 	    my ($not, $env, $text) = ($1, $2, $3);
-	    die "unsuported ifdef usage - implement me" if $text;
+	    die "unsupported ifdef usage - implement me" if $text;
 
 	    my $skip = !exists($attributes->{$env}) ? 1 : 0;
 	    $skip = ($skip ? 0 : 1 ) if $not;
@@ -222,7 +222,7 @@ sub prepare_adoc_file {
 	    next;
 	} elsif ($line =~ m/^endif::(\S+)\[(.*)\]\s*$/) {
 	    my ($env, $text) = ($1, $2);
-	    die "unsuported ifdef usage - implement me" if $text;
+	    die "unsupported ifdef usage - implement me" if $text;
 	    pop_environment($env);
 	    next;
 	}
diff --git a/asciidoc/pmg-docs.css b/asciidoc/pmg-docs.css
index 45e2b11..8d1b8f8 100644
--- a/asciidoc/pmg-docs.css
+++ b/asciidoc/pmg-docs.css
@@ -106,7 +106,7 @@ div.admonitionblock td.icon > img {
         color: var(--pdt-text);
     }
 
-    /* reduce the brigthness of images a bit and make it reversable
+    /* reduce the brightness of images a bit and make it reversable
      * through hovering over them.
      */
     .image > img {
@@ -161,7 +161,7 @@ div.admonitionblock td.icon > img {
         filter: invert(100%) hue-rotate(180deg) brightness(90%);
     }
 
-    /* fixes the black text on unorderd lists */
+    /* fixes the black text on unordered lists */
     ul > li > * {
         color: var(--pdt-text);
     }
diff --git a/scan-adoc-refs b/scan-adoc-refs
index e7767dc..e80b02e 100755
--- a/scan-adoc-refs
+++ b/scan-adoc-refs
@@ -70,7 +70,7 @@ sub pop_environment {
     pop @$env_stack;
     my $res = pop @$env_name_stack;
 
-    die "environment missmatch ($res != $env)\n" if $res ne $env;
+    die "environment mismatch ($res != $env)\n" if $res ne $env;
 }
 
 sub register_include {
@@ -146,12 +146,12 @@ sub scan_adoc_file {
     while (defined (my $line = <$fh>)) {
 	if ($line =~ m/^if(n?)def::(\S+)\[(.*)\]\s*$/) {
 	    my ($not, $env, $text) = ($1, $2, $3);
-	    die "unsuported ifdef usage - implement me" if $text;
+	    die "unsupported ifdef usage - implement me" if $text;
 	    push_environment($env, $not);
 	    next;
 	} elsif ($line =~ m/^endif::(\S+)\[(.*)\]\s*$/) {
 	    my ($env, $text) = ($1, $2);
-	    die "unsuported ifdef usage - implement me" if $text;
+	    die "unsupported ifdef usage - implement me" if $text;
 	    pop_environment($env);
 	    next;
 	} elsif ($line =~ m/^include::(\S+)\[.*\]\s*$/) {
-- 
2.39.2



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [pmg-devel] [PATCH pmg-docs 2/3] fix typos in documentation
  2024-08-07 10:49 [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files Maximiliano Sandoval
@ 2024-08-07 10:49 ` Maximiliano Sandoval
  2024-08-07 10:49 ` [pmg-devel] [PATCH pmg-docs 3/3] latex: fix typo in comment Maximiliano Sandoval
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Maximiliano Sandoval @ 2024-08-07 10:49 UTC (permalink / raw)
  To: pmg-devel

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 pmg-installation.adoc | 2 +-
 pmg-rule-macros.adoc  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pmg-installation.adoc b/pmg-installation.adoc
index 25d16a7..4209784 100644
--- a/pmg-installation.adoc
+++ b/pmg-installation.adoc
@@ -209,7 +209,7 @@ Accessing the Management Interface Post-Installation
 
 [thumbnail="screenshot/pmg-gui-login-window.png"]
 
-After a succesful installation and reboot of the system you can use the {pmg}
+After a successful installation and reboot of the system you can use the {pmg}
 web interface for further configuration.
 
 . Point your browser to the IP address given during the installation and port
diff --git a/pmg-rule-macros.adoc b/pmg-rule-macros.adoc
index d3b6aa5..e0b9d18 100644
--- a/pmg-rule-macros.adoc
+++ b/pmg-rule-macros.adoc
@@ -25,5 +25,5 @@ following macros are defined:
 |__SENDER_IP__       |IP address of sending host
 |__VERSION__         |The current software version (proxmox mail gateway)
 |__FILENAME__        |Attachment file name
-|__SPAMSTARS__       |A series of "*" charactes where each one represents a full score (__SPAMLEVEL__) point
+|__SPAMSTARS__       |A series of "*" characters where each one represents a full score (__SPAMLEVEL__) point
 |======
-- 
2.39.2



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [pmg-devel] [PATCH pmg-docs 3/3] latex: fix typo in comment
  2024-08-07 10:49 [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files Maximiliano Sandoval
  2024-08-07 10:49 ` [pmg-devel] [PATCH pmg-docs 2/3] fix typos in documentation Maximiliano Sandoval
@ 2024-08-07 10:49 ` Maximiliano Sandoval
  2024-08-07 12:05 ` [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files Stoiko Ivanov
  2024-08-08 12:08 ` [pmg-devel] applied-series: " Stoiko Ivanov
  3 siblings, 0 replies; 6+ messages in thread
From: Maximiliano Sandoval @ 2024-08-07 10:49 UTC (permalink / raw)
  To: pmg-devel

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 asciidoc/pmg-dblatex.xsl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/asciidoc/pmg-dblatex.xsl b/asciidoc/pmg-dblatex.xsl
index 76edab8..11fa23d 100644
--- a/asciidoc/pmg-dblatex.xsl
+++ b/asciidoc/pmg-dblatex.xsl
@@ -3,7 +3,7 @@
 dblatex(1) XSL user stylesheet for asciidoc(1).
 See dblatex(1) -p option.
 
-modified for Proxmox VE documenation.
+modified for Proxmox VE documentation.
 -->
 <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0">
 
-- 
2.39.2



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files
  2024-08-07 10:49 [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files Maximiliano Sandoval
  2024-08-07 10:49 ` [pmg-devel] [PATCH pmg-docs 2/3] fix typos in documentation Maximiliano Sandoval
  2024-08-07 10:49 ` [pmg-devel] [PATCH pmg-docs 3/3] latex: fix typo in comment Maximiliano Sandoval
@ 2024-08-07 12:05 ` Stoiko Ivanov
  2024-08-07 12:08   ` Maximiliano Sandoval
  2024-08-08 12:08 ` [pmg-devel] applied-series: " Stoiko Ivanov
  3 siblings, 1 reply; 6+ messages in thread
From: Stoiko Ivanov @ 2024-08-07 12:05 UTC (permalink / raw)
  To: Maximiliano Sandoval; +Cc: pmg-devel

Thanks for the patches - much appreciated!

did you find those manually - or did you use some tool like `codespell`?
(in any case that information might be worth including in the commit
messages)


On Wed,  7 Aug 2024 12:49:42 +0200
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:

> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files
  2024-08-07 12:05 ` [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files Stoiko Ivanov
@ 2024-08-07 12:08   ` Maximiliano Sandoval
  0 siblings, 0 replies; 6+ messages in thread
From: Maximiliano Sandoval @ 2024-08-07 12:08 UTC (permalink / raw)
  To: Stoiko Ivanov; +Cc: pmg-devel

Stoiko Ivanov <s.ivanov@proxmox.com> writes:

> Thanks for the patches - much appreciated!
>
> did you find those manually - or did you use some tool like `codespell`?
> (in any case that information might be worth including in the commit
> messages)
>
>
> On Wed,  7 Aug 2024 12:49:42 +0200
> Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:
>
>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>> ---

Found with typos-cli (`cargo install typos-cli`):

    typos --exclude .git --exclude tests --exclude images --exclude changelog

Should I add that to all commits and send v2?

-- 
Maximiliano


_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [pmg-devel] applied-series: [PATCH pmg-docs 1/3] fix typos in perl and css files
  2024-08-07 10:49 [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files Maximiliano Sandoval
                   ` (2 preceding siblings ...)
  2024-08-07 12:05 ` [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files Stoiko Ivanov
@ 2024-08-08 12:08 ` Stoiko Ivanov
  3 siblings, 0 replies; 6+ messages in thread
From: Stoiko Ivanov @ 2024-08-08 12:08 UTC (permalink / raw)
  To: Maximiliano Sandoval; +Cc: pmg-devel

applied all 3 patches with the reference to typos-cli added to the commit
message - Thanks!


On Wed,  7 Aug 2024 12:49:42 +0200
Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:

> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  asciidoc-pmg.in       | 6 +++---
>  asciidoc/pmg-docs.css | 4 ++--
>  scan-adoc-refs        | 6 +++---
>  3 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/asciidoc-pmg.in b/asciidoc-pmg.in
> index 532ea7f..fefca5e 100644
> --- a/asciidoc-pmg.in
> +++ b/asciidoc-pmg.in
> @@ -79,7 +79,7 @@ sub pop_environment {
>      die "unable to pop env '$env'" if !defined($last_stack_entry);
>  
>      my ($last_env, $skip) = @$last_stack_entry;
> -    die "environment missmatch (${last_env} != $env)\n" if $last_env ne $env;
> +    die "environment mismatch (${last_env} != $env)\n" if $last_env ne $env;
>  
>      if (!scalar(@$env_stack)) {
>  	$env_skip = 0;
> @@ -213,7 +213,7 @@ sub prepare_adoc_file {
>  	chomp $line;
>  	if ($line =~ m/^if(n?)def::(\S+)\[(.*)\]\s*$/) {
>  	    my ($not, $env, $text) = ($1, $2, $3);
> -	    die "unsuported ifdef usage - implement me" if $text;
> +	    die "unsupported ifdef usage - implement me" if $text;
>  
>  	    my $skip = !exists($attributes->{$env}) ? 1 : 0;
>  	    $skip = ($skip ? 0 : 1 ) if $not;
> @@ -222,7 +222,7 @@ sub prepare_adoc_file {
>  	    next;
>  	} elsif ($line =~ m/^endif::(\S+)\[(.*)\]\s*$/) {
>  	    my ($env, $text) = ($1, $2);
> -	    die "unsuported ifdef usage - implement me" if $text;
> +	    die "unsupported ifdef usage - implement me" if $text;
>  	    pop_environment($env);
>  	    next;
>  	}
> diff --git a/asciidoc/pmg-docs.css b/asciidoc/pmg-docs.css
> index 45e2b11..8d1b8f8 100644
> --- a/asciidoc/pmg-docs.css
> +++ b/asciidoc/pmg-docs.css
> @@ -106,7 +106,7 @@ div.admonitionblock td.icon > img {
>          color: var(--pdt-text);
>      }
>  
> -    /* reduce the brigthness of images a bit and make it reversable
> +    /* reduce the brightness of images a bit and make it reversable
>       * through hovering over them.
>       */
>      .image > img {
> @@ -161,7 +161,7 @@ div.admonitionblock td.icon > img {
>          filter: invert(100%) hue-rotate(180deg) brightness(90%);
>      }
>  
> -    /* fixes the black text on unorderd lists */
> +    /* fixes the black text on unordered lists */
>      ul > li > * {
>          color: var(--pdt-text);
>      }
> diff --git a/scan-adoc-refs b/scan-adoc-refs
> index e7767dc..e80b02e 100755
> --- a/scan-adoc-refs
> +++ b/scan-adoc-refs
> @@ -70,7 +70,7 @@ sub pop_environment {
>      pop @$env_stack;
>      my $res = pop @$env_name_stack;
>  
> -    die "environment missmatch ($res != $env)\n" if $res ne $env;
> +    die "environment mismatch ($res != $env)\n" if $res ne $env;
>  }
>  
>  sub register_include {
> @@ -146,12 +146,12 @@ sub scan_adoc_file {
>      while (defined (my $line = <$fh>)) {
>  	if ($line =~ m/^if(n?)def::(\S+)\[(.*)\]\s*$/) {
>  	    my ($not, $env, $text) = ($1, $2, $3);
> -	    die "unsuported ifdef usage - implement me" if $text;
> +	    die "unsupported ifdef usage - implement me" if $text;
>  	    push_environment($env, $not);
>  	    next;
>  	} elsif ($line =~ m/^endif::(\S+)\[(.*)\]\s*$/) {
>  	    my ($env, $text) = ($1, $2);
> -	    die "unsuported ifdef usage - implement me" if $text;
> +	    die "unsupported ifdef usage - implement me" if $text;
>  	    pop_environment($env);
>  	    next;
>  	} elsif ($line =~ m/^include::(\S+)\[.*\]\s*$/) {



_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-08-08 12:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-07 10:49 [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files Maximiliano Sandoval
2024-08-07 10:49 ` [pmg-devel] [PATCH pmg-docs 2/3] fix typos in documentation Maximiliano Sandoval
2024-08-07 10:49 ` [pmg-devel] [PATCH pmg-docs 3/3] latex: fix typo in comment Maximiliano Sandoval
2024-08-07 12:05 ` [pmg-devel] [PATCH pmg-docs 1/3] fix typos in perl and css files Stoiko Ivanov
2024-08-07 12:08   ` Maximiliano Sandoval
2024-08-08 12:08 ` [pmg-devel] applied-series: " Stoiko Ivanov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal